[HBASE-16272] Overflow in ServerName's compareTo method

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0, 1.1.6, 0.98.21, 1.2.3, 2.0.0
• Assignee: Hua Xiang
• Reporter: Hua Xiang
• Created: 22/Jul/16 02:25
• Updated: 18/Jun/18 15:08
• Resolved: 22/Jul/16 23:36

Description

Looking at the ServerName's compareTo(),

https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/ServerName.java#L303

It converts the return int value by converting long to int like (int)(longValue), which could be incorrect when it overflows, need to replace it with Long.compareTo(a,b).

mbertozzi found some others as well, such as
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java#L990

Issue Links

• is depended upon by: HBASE-16275 Change ServerManager#onlineServers from ConcurrentHashMap to ConcurrentSkipListMap