[HBASE-16207] can't restore snapshot without "Admin" permission

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0, 1.2.1, 1.1.5, 2.0.0
• Fix Version/s: 1.3.0, 1.1.6, 0.98.21, 1.2.3, 2.0.0
• Component/s: master, snapshots
• Assignee: Matteo Bertozzi
• Reporter: Matteo Bertozzi
• Created: 11/Jul/16 17:15
• Updated: 21/Oct/16 18:35
• Resolved: 12/Jul/16 13:29

Description

MasterRpcServices.restoreSnapshot() tries to verify if the NS exists before starting the restore, but instead of calling ensureNamespaceExists() it calls master.getNamespace() which requires ADMIN permission to get the NS descriptor.

public RestoreSnapshotResponse restoreSnapshot(RpcController controller,
...
  // Ensure namespace exists. Will throw exception if non-known NS.
  master.getNamespace(dstTable.getNamespaceAsString());

unfortunately i'm not aware of any unit-test that cover this kind of situations. we cover single ACLs from the TestAccessController but we don't exercise rpc calls and verify if there is more than one check on the ACLs like in this case