[HBASE-16176] Bug fixes/improvements on HBASE-15650 Remove TimeRangeTracker as point of contention when many threads reading a StoreFile

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0, 0.98.20
• Fix Version/s: 1.3.0, 2.0.0
• Component/s: Performance
• Hadoop Flags: Reviewed
• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 05/Jul/16 18:52
• Updated: 17/Jun/22 17:31
• Resolved: 09/Jul/16 15:41

Description

Debugging the parent issue, came up with some improvements on old HBASE-15650 "Remove TimeRangeTracker as point of contention when many threads reading a StoreFile". Lets get them in. Here are the changes:

  6      Change HFile Writer constructor so we pass in the TimeRangeTracker, if one,
  7      on construction rather than set later (the flag and reference were not
  8      volatile so could have made for issues in concurrent case) 2. Make sure the
  9      construction of a TimeRange from a TimeRangeTracer on open of an HFile Reader
 10      never makes a bad minimum value, one that would preclude us reading any
 11      values from a file (add a log and set min to 0)
 12     M hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
 13      Call through to next constructor (if minStamp was 0, we'd skip setting allTime=true)
 14     M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
 15      Add constructor override that takes a TimeRangeTracker (set when flushing but
 16      not when compacting)
 17     M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
 18      Add override creating an HFile in tmp that takes a TimeRangeTracker
 19     M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
 20      Add override for HFile Writer that takes a TimeRangeTracker
 21      Take it on construction instead of having it passed by a setter later (flags
 22      and reference set by the setter were not volatile... could have been prob
 23      in concurrent case)
 24     M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java
 25      Log WARN if bad initial TimeRange value (and then 'fix' it)
 26     M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTimeRangeTracker.java
 27      A few tests to prove serialization works as expected and that we'll get a bad min if
 28      not constructed properly.

Issue Links

• relates to: HBASE-16175 Backport HBASE-15650 (Remove TimeRangeTracker as point of contention when many threads reading a StoreFile) to 0.98
• links to: Review Board (branch-1.3)
• links to: Review Board (master)