[HBASE-16071] The VisibilityLabelFilter and AccessControlFilter should not count the "delete cell"

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Abandoned
• Affects Version/s: 2.0.0
• Assignee: Unassigned
• Reporter: Chia-Ping Tsai
• Created: 20/Jun/16 11:32
• Updated: 12/Jun/22 18:44
• Resolved: 12/Jun/22 18:44

Description

The VisibilityLabelFilter will see and count the "delete cell" if the scan.isRaw() returns true, so the (put) cell will be skipped if it has lower version than "delete cell"

The critical code is shown below:

VisibilityLabelFilter.java

  public ReturnCode filterKeyValue(Cell cell) throws IOException {
    if (curFamily.getBytes() == null
        || !(CellUtil.matchingFamily(cell, curFamily.getBytes(), curFamily.getOffset(),
            curFamily.getLength()))) {
      curFamily.set(cell.getFamilyArray(), cell.getFamilyOffset(), cell.getFamilyLength());
      // For this family, all the columns can have max of curFamilyMaxVersions versions. No need to
      // consider the older versions for visibility label check.
      // Ideally this should have been done at a lower layer by HBase (?)
      curFamilyMaxVersions = cfVsMaxVersions.get(curFamily);
      // Family is changed. Just unset curQualifier.
      curQualifier.unset();
    }
    if (curQualifier.getBytes() == null
        || !(CellUtil.matchingQualifier(cell, curQualifier.getBytes(), curQualifier.getOffset(),
            curQualifier.getLength()))) {
      curQualifier.set(cell.getQualifierArray(), cell.getQualifierOffset(),
          cell.getQualifierLength());
      curQualMetVersions = 0;
    }
    curQualMetVersions++;
    if (curQualMetVersions > curFamilyMaxVersions) {
      return ReturnCode.SKIP;
    }

    return this.expEvaluator.evaluate(cell) ? ReturnCode.INCLUDE : ReturnCode.SKIP;
  }

VisibilityLabelFilter.java