[HBASE-16066] Resolve RpC_REPEATED_CONDITIONAL_TEST findbugs warnings in HMaster

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Assignee: Yu Li
• Reporter: Yu Li
• Created: 19/Jun/16 09:04
• Updated: 19/Jun/16 15:38
• Resolved: 19/Jun/16 09:27

Description

As titled, find this issue in findbugs report of HBASE-16032:

Code	Warning
RpC	Repeated conditional test in org.apache.hadoop.hbase.master.HMaster.normalizeRegions()
Bug type RpC_REPEATED_CONDITIONAL_TEST (click for details) 
In class org.apache.hadoop.hbase.master.HMaster
In method org.apache.hadoop.hbase.master.HMaster.normalizeRegions()
At HMaster.java:[line 1388]
At HMaster.java:[line 1388]

And we could find below lines in HMaster line 1388:

        if (table.isSystemTable() || (tblDesc != null &&
            tblDesc != null &&
            !tblDesc.isNormalizationEnabled())) {

where there's a duplicated check, introduced by HBASE-15467