[HBASE-15922] Fix waitForMaximumCurrentTasks logic in AsyncProcess

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.2.1, 1.1.4, 2.0.0
• Assignee: Yu Li
• Reporter: Yu Li
• Created: 31/May/16 12:52
• Updated: 31/May/16 13:13
• Resolved: 31/May/16 13:13

Description

In current implementation of AsyncProcess#waitForMaximumCurrentTasks, we have below codes:

while ((currentInProgress = this.tasksInProgress.get()) > max) {
      ...
      try {
        synchronized (this.tasksInProgress) {
          if (tasksInProgress.get() != oldInProgress) break;
          this.tasksInProgress.wait(100);
        }
      } catch (InterruptedException e) {
        throw new InterruptedIOException("#" + id + ", interrupted." +
            " currentNumberOfTask=" + currentInProgress);
      }
}

Which will cause end of while loop if there's any task done inside one loop making taskInProgress.get() no longer equals to oldInProgress

This is a regression issue caused by HBASE-11403 and only exists in branch-1/master branch, we could easily see the difference comparing to latest 0.98 code.

Issue Links

• duplicates: HBASE-15811 Batch Get after batch Put does not fetch all Cells