[HBASE-15829] hbase.client.retries.number has different meanings in branch-1 and master

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Invalid
• Affects Version/s: 2.0.0
• Component/s: Client
• Assignee: Unassigned Assign to me
• Reporter: Guanghao Zhang
• Created: 14/May/16 05:07
• Updated: 09/Sep/16 02:59
• Resolved: 09/Sep/16 02:59

Description

The comment of hbase.client.retries.number is:

  /**  
   * Parameter name for maximum retries, used as maximum for all retryable
   * operations such as fetching of the root region from root region server,
   * getting a cell's value, starting a row update, etc.
   */
  public static final String HBASE_CLIENT_RETRIES_NUMBER = "hbase.client.retries.number";

In branch-1, the max attempts number equals with hbase.client.retries.number. But in master, the max attempts number equals with hbase.client.retries.number + 1.

For RpcRetryingCaller.

this.retries = retries; // branch-1

this.maxAttempts = retries + 1; // master

For AsyncProcess:

    this.numTries = conf.getInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER,
        HConstants.DEFAULT_HBASE_CLIENT_RETRIES_NUMBER); // branch-1

    // how many times we could try in total, one more than retry number
    this.numTries = conf.getInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER,
        HConstants.DEFAULT_HBASE_CLIENT_RETRIES_NUMBER) + 1; // master

Issue Links

• is superceded by: HBASE-14521 Unify the semantic of hbase.client.retries.number