[HBASE-15795] Cleanup all classes in package org.apache.hadoop.hbase.ipc for code style

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Jurriaan Mous
• Reporter: Jurriaan Mous
• Created: 07/May/16 12:52
• Updated: 10/May/16 05:51
• Resolved: 07/May/16 17:03

Description

While making adjustments for the async client I also need to fix code styling on the relevant classes. I want to do it all at once for ipc package so it does not mess up the diffs of future changes. I left out the classes I already fixed in patch in HBASE-15793

• Fixed import order
• Added curly brackets to all one line if statements
• Simplified generics with diamond operators where applicable
• Made private fields final when they were able
• use try with resource where it could be used
• renamed variables which were obscuring class fields
• Added documentation to empty @ doc fields
• Removed unnecessary setting to null
• Removed unused getDelimitedMessageAsByteBuffer and readChunked methods from private IPCUtil class