[HBASE-15794] Fix Findbugs instanceof always true issue in MultiServerCallable

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Jurriaan Mous
• Reporter: Jurriaan Mous
• Created: 07/May/16 12:40
• Updated: 07/May/16 18:05
• Resolved: 07/May/16 17:05

Description

Findbugs keeps reporting this issue on Client:

Code Warning
BC instanceof will always return true for all nonnull values in org.apache.hadoop.hbase.client.MultiServerCallable.isCellBlock(), since all org.apache.hadoop.hbase.client.ClusterConnection are instances of org.apache.hadoop.hbase.client.ClusterConnection
Bug type BC_VACUOUS_INSTANCEOF (click for details)
In class org.apache.hadoop.hbase.client.MultiServerCallable
In method org.apache.hadoop.hbase.client.MultiServerCallable.isCellBlock()
Actual type org.apache.hadoop.hbase.client.ClusterConnection
Expected org.apache.hadoop.hbase.client.ClusterConnection
At MultiServerCallable.java:[line 141]

https://builds.apache.org/job/PreCommit-HBASE-Build/1812/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html