Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-14350 Procedure V2 Phase 2: Assignment Manager
  3. HBASE-15778

replace master.am and master.sm direct access with getter calls

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0
    • master
    • None

    Description

      MasterRpcServices seems to access directly a bunch of members of HMaster. I think this is because when we split HMaster and MaterRpcServices we just did a find & replace.

      I was trying to mock and have a different AssignmentManager and ServerManager but it got impossible with those access directly.
      so, here a patch to avoid the direct access to AM and SM.

      There are many more members that can be made private but I'm lazy. so this pass is only AM, SM related

      Attachments

        1. HBASE-15778-v0.patch
          15 kB
          Matteo Bertozzi

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mbertozzi Matteo Bertozzi
            mbertozzi Matteo Bertozzi
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment