[HBASE-15740] Replication source.shippedKBs metric is undercounting because it is in KB

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0, 0.98.20, 2.0.0
• Hadoop Flags: Reviewed
• Release Note: Removed Replication source.shippedKBs metric in favor of source.shippedBytes
• Assignee: Enis Soztutar
• Reporter: Enis Soztutar
• Created: 29/Apr/16 23:56
• Updated: 01/Jul/22 20:31
• Resolved: 09/May/16 17:57

Description

In a cluster where there is replication going on, I've noticed that this is always 0:

    "source.shippedKBs" : 0,

Looking at the source reveals why:

          metrics.shipBatch(currentNbOperations, currentSize / 1024, currentNbHFiles);

It is always undercounting because we discard remaining bytes after KB boundary. This is specially a problem when we are always shipping small batches <1KB.