[HBASE-15693] Reconsider the ImportOrder rule of checkstyle

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0, 1.2.1, 1.0.3, 1.1.4, 0.98.19, 1.4.0, 2.0.0
• Fix Version/s: 1.3.0, 1.0.4, 1.2.2, 0.98.20, 2.0.0
• Component/s: build
• Labels: checkstyle
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 22/Apr/16 11:51
• Updated: 09/Nov/17 00:45
• Resolved: 28/May/16 10:43

Description

I have been confused many times with the wrong import order checkstyle warnings in the pre commit result. And I haven't found any developer guide which tells me what is the right order so this time I decided to read the rule by myself.

In the ImportOrder section, we declare sortStaticImportsAlphabetically which can only work with option 'top' or 'bottom'(which means place static imports on top or bottom) and use the default option which is 'under'.

I prefer placing static import on top, so I suggest here we set option to 'top'.