[HBASE-15679] Assertion on wrong variable in TestReplicationThrottler#testThrottling

• Type: Test
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.3.0, 0.98.19, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 19/Apr/16 23:02
• Updated: 09/Nov/17 00:43
• Resolved: 20/Apr/16 14:12

Description

Sometimes TestReplicationThrottler#testThrottling failed with:

java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.hbase.replication.regionserver.TestReplicationThrottler.testThrottling(TestReplicationThrottler.java:75)

Looking closer, we can see that the wrong variable is used for the assertion:

    if (ticks2 != 10000 && ticks2 != 9999) {
      assertTrue(ticks1 >= 7500 && ticks1 <=10000);
    }