Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15679

Assertion on wrong variable in TestReplicationThrottler#testThrottling

    XMLWordPrintableJSON

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0, 0.98.19, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Sometimes TestReplicationThrottler#testThrottling failed with:

      java.lang.AssertionError: null
      	at org.junit.Assert.fail(Assert.java:86)
      	at org.junit.Assert.assertTrue(Assert.java:41)
      	at org.junit.Assert.assertTrue(Assert.java:52)
      	at org.apache.hadoop.hbase.replication.regionserver.TestReplicationThrottler.testThrottling(TestReplicationThrottler.java:75)
      

      Looking closer, we can see that the wrong variable is used for the assertion:

          if (ticks2 != 10000 && ticks2 != 9999) {
            assertTrue(ticks1 >= 7500 && ticks1 <=10000);
          }
      

        Attachments

        1. 15679.v1.patch
          0.8 kB
          Ted Yu

          Activity

            People

            • Assignee:
              yuzhihong@gmail.com Ted Yu
              Reporter:
              yuzhihong@gmail.com Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: