Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-14123 HBase Backup/Restore Phase 2
  3. HBASE-15584

Revisit handling of BackupState#CANCELLED

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • None
    • None
    • None
    • Reviewed

    Description

      During review of HBASE-15411, Enis made the following point:

      nobody puts the backup in cancelled state. setCancelled() is not used. So if I abort a backup, who writes to the system table the new state? 
      
      Not sure whether this is a phase 1 patch issue or due to this patch. We can open a new jira and address it there if you do not want to do it in this patch. 
      
      Also maybe this should be named ABORTED rather than CANCELLED.
      

      This issue is to decide whether this state should be kept (e.g. through notification from procedure V2 framework in response to abortion).

      If it is to be kept, the state should be renamed ABORTED.

      Attachments

        1. 15584.v1.txt
          0.8 kB
          Ted Yu
        2. 15584.v2.txt
          7 kB
          Ted Yu

        Activity

          People

            yuzhihong@gmail.com Ted Yu
            yuzhihong@gmail.com Ted Yu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: