[HBASE-15563] 'counter' may overflow in BoundedGroupingStrategy

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.3.0, 2.0.0
• Component/s: wal
• Labels: beginner
• Hadoop Flags: Reviewed
• Assignee: Matt Warhaftig
• Reporter: Duo Zhang
• Created: 30/Mar/16 09:24
• Updated: 09/Nov/17 00:51
• Resolved: 05/May/16 17:31

Description

groupName = groupNames[counter.getAndIncrement() % groupNames.length];

Theoretically, counter can overflow and becomes negative then causes an ArrayIndexOutOfBoundsException.

But in practice, we need 2 billions different identifiers to make this happen, and before the overflow we will run into OOM because of a huge groupNameCache...

So not sure if it is worth to fix