Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.3.0, 1.4.0, 2.0.0
    • 1.3.0, 2.0.0
    • None
    • None
    • Reviewed

    Description

      There are two problems

      1. AsyncIPC will throw IOException when connection reset so we need to change the catch type in testRpcMaxRequestSize.

      2. AsyncRpcChannel does not deal with channelInactive event in netty.

      Attachments

        1. HBASE-15520-v1.patch
          32 kB
          Duo Zhang
        2. HBASE-15520.patch
          29 kB
          Duo Zhang

        Issue Links

          Activity

            zhangduo Duo Zhang added a comment -

            Seems the QA bot ignored us...Retry

            zhangduo Duo Zhang added a comment - Seems the QA bot ignored us...Retry
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
            0 mvndep 0m 44s Maven dependency ordering for branch
            +1 mvninstall 4m 10s master passed
            +1 compile 2m 57s master passed with JDK v1.8.0
            +1 compile 2m 7s master passed with JDK v1.7.0_79
            +1 checkstyle 8m 14s master passed
            +1 mvneclipse 1m 7s master passed
            +1 findbugs 7m 27s master passed
            +1 javadoc 2m 31s master passed with JDK v1.8.0
            +1 javadoc 2m 20s master passed with JDK v1.7.0_79
            0 mvndep 0m 13s Maven dependency ordering for patch
            +1 mvninstall 2m 40s the patch passed
            +1 compile 2m 44s the patch passed with JDK v1.8.0
            +1 javac 2m 44s the patch passed
            +1 compile 2m 18s the patch passed with JDK v1.7.0_79
            +1 javac 2m 18s the patch passed
            -1 checkstyle 2m 16s hbase-client: patch generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6)
            -1 checkstyle 1m 51s hbase-client: patch generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6)
            -1 checkstyle 1m 50s hbase-server: patch generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6)
            -1 checkstyle 1m 55s hbase-server: patch generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6)
            +1 mvneclipse 0m 58s the patch passed
            +1 whitespace 0m 0s Patch has no whitespace issues.
            +1 hadoopcheck 31m 22s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
            +1 findbugs 8m 34s the patch passed
            +1 javadoc 2m 17s the patch passed with JDK v1.8.0
            +1 javadoc 2m 12s the patch passed with JDK v1.7.0_79
            +1 unit 1m 6s hbase-client in the patch passed.
            +1 unit 1m 12s hbase-client in the patch passed.
            -1 unit 123m 12s hbase-server in the patch failed.
            -1 unit 123m 12s hbase-server in the patch failed.
            +1 asflicense 1m 1s Patch does not generate ASF License warnings.
            344m 16s



            Reason Tests
            Timed out junit tests org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
              org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures



            Subsystem Report/Notes
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794947/HBASE-15520.patch
            JIRA Issue HBASE-15520
            Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
            uname Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / cadfb21
            Default Java 1.7.0_79
            Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79
            findbugs v3.0.0
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/diff-checkstyle-hbase-client.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/diff-checkstyle-hbase-client.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/diff-checkstyle-hbase-server.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/diff-checkstyle-hbase-server.txt
            unit https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/patch-unit-hbase-server.txt
            unit https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/patch-unit-hbase-server.txt
            unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/patch-unit-hbase-server.txt https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/patch-unit-hbase-server.txt
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/1153/testReport/
            modules C: hbase-client hbase-client hbase-server hbase-server U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/1153/console
            Powered by Apache Yetus 0.2.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 44s Maven dependency ordering for branch +1 mvninstall 4m 10s master passed +1 compile 2m 57s master passed with JDK v1.8.0 +1 compile 2m 7s master passed with JDK v1.7.0_79 +1 checkstyle 8m 14s master passed +1 mvneclipse 1m 7s master passed +1 findbugs 7m 27s master passed +1 javadoc 2m 31s master passed with JDK v1.8.0 +1 javadoc 2m 20s master passed with JDK v1.7.0_79 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 2m 40s the patch passed +1 compile 2m 44s the patch passed with JDK v1.8.0 +1 javac 2m 44s the patch passed +1 compile 2m 18s the patch passed with JDK v1.7.0_79 +1 javac 2m 18s the patch passed -1 checkstyle 2m 16s hbase-client: patch generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6) -1 checkstyle 1m 51s hbase-client: patch generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6) -1 checkstyle 1m 50s hbase-server: patch generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6) -1 checkstyle 1m 55s hbase-server: patch generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6) +1 mvneclipse 0m 58s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 31m 22s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 findbugs 8m 34s the patch passed +1 javadoc 2m 17s the patch passed with JDK v1.8.0 +1 javadoc 2m 12s the patch passed with JDK v1.7.0_79 +1 unit 1m 6s hbase-client in the patch passed. +1 unit 1m 12s hbase-client in the patch passed. -1 unit 123m 12s hbase-server in the patch failed. -1 unit 123m 12s hbase-server in the patch failed. +1 asflicense 1m 1s Patch does not generate ASF License warnings. 344m 16s Reason Tests Timed out junit tests org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures   org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794947/HBASE-15520.patch JIRA Issue HBASE-15520 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / cadfb21 Default Java 1.7.0_79 Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/diff-checkstyle-hbase-client.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/diff-checkstyle-hbase-client.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/diff-checkstyle-hbase-server.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/diff-checkstyle-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/patch-unit-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/patch-unit-hbase-server.txt https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/1153/testReport/ modules C: hbase-client hbase-client hbase-server hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/1153/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
            stack Michael Stack added a comment -

            The patch is 80% formatting changes. Makes it harder to review. I think I understand what is going on and looks reasonable to me. +1. Try and fix checkstyles on commit.

            stack Michael Stack added a comment - The patch is 80% formatting changes. Makes it harder to review. I think I understand what is going on and looks reasonable to me. +1. Try and fix checkstyles on commit.
            zhangduo Duo Zhang added a comment -

            Fix the checkstyle issues

            zhangduo Duo Zhang added a comment - Fix the checkstyle issues
            zhangduo Duo Zhang added a comment -

            Checked locally, the checkstyle errors in https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/diff-checkstyle-hbase-client.txt were all gone.

            Seems the Pre-Commit Admin job has been waiting for an executor for a long time, so let's commit this first.

            busbey Can we run Pre-Commit Admin job on the jenkins server machine directly? It is not a heavy job I suppose? Thanks.

            zhangduo Duo Zhang added a comment - Checked locally, the checkstyle errors in https://builds.apache.org/job/PreCommit-HBASE-Build/1153/artifact/patchprocess/diff-checkstyle-hbase-client.txt were all gone. Seems the Pre-Commit Admin job has been waiting for an executor for a long time, so let's commit this first. busbey Can we run Pre-Commit Admin job on the jenkins server machine directly? It is not a heavy job I suppose? Thanks.
            zhangduo Duo Zhang added a comment -

            Pushed to branch-1.3+. Thanks stack for reviewing.

            zhangduo Duo Zhang added a comment - Pushed to branch-1.3+. Thanks stack for reviewing.
            busbey Sean Busbey added a comment -

            Sean Busbey Can we run Pre-Commit Admin job on the jenkins server machine directly? It is not a heavy job I suppose? Thanks.

            I haven't historically been a maintainer for the admin job. I'm not sure what its requirements are.

            busbey Sean Busbey added a comment - Sean Busbey Can we run Pre-Commit Admin job on the jenkins server machine directly? It is not a heavy job I suppose? Thanks. I haven't historically been a maintainer for the admin job. I'm not sure what its requirements are.
            hudson Hudson added a comment -

            SUCCESS: Integrated in HBase-1.3-IT #579 (See https://builds.apache.org/job/HBase-1.3-IT/579/)
            HBASE-15520 Fix broken TestAsyncIPC (zhangduo: rev 9fa44a8126bd23d6dff5db2091bc5279fabc7e6e)

            • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java
            • hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
            • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncServerResponseHandler.java
            hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.3-IT #579 (See https://builds.apache.org/job/HBase-1.3-IT/579/ ) HBASE-15520 Fix broken TestAsyncIPC (zhangduo: rev 9fa44a8126bd23d6dff5db2091bc5279fabc7e6e) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncServerResponseHandler.java
            hudson Hudson added a comment -

            FAILURE: Integrated in HBase-Trunk_matrix #803 (See https://builds.apache.org/job/HBase-Trunk_matrix/803/)
            HBASE-15520 Fix broken TestAsyncIPC (zhangduo: rev fd5c0934b60664ecdde21a994910953339c7060d)

            • hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
            • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java
            • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncServerResponseHandler.java
            hudson Hudson added a comment - FAILURE: Integrated in HBase-Trunk_matrix #803 (See https://builds.apache.org/job/HBase-Trunk_matrix/803/ ) HBASE-15520 Fix broken TestAsyncIPC (zhangduo: rev fd5c0934b60664ecdde21a994910953339c7060d) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncServerResponseHandler.java
            hudson Hudson added a comment -

            FAILURE: Integrated in HBase-1.4 #49 (See https://builds.apache.org/job/HBase-1.4/49/)
            HBASE-15520 Fix broken TestAsyncIPC (zhangduo: rev 9fa44a8126bd23d6dff5db2091bc5279fabc7e6e)

            • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java
            • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncServerResponseHandler.java
            • hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
            hudson Hudson added a comment - FAILURE: Integrated in HBase-1.4 #49 (See https://builds.apache.org/job/HBase-1.4/49/ ) HBASE-15520 Fix broken TestAsyncIPC (zhangduo: rev 9fa44a8126bd23d6dff5db2091bc5279fabc7e6e) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncServerResponseHandler.java hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
            hudson Hudson added a comment -

            FAILURE: Integrated in HBase-1.3 #621 (See https://builds.apache.org/job/HBase-1.3/621/)
            HBASE-15520 Fix broken TestAsyncIPC (zhangduo: rev e07b662f9bc88ffff43b75bc870f76f771a64111)

            • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java
            • hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
            • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncServerResponseHandler.java
            hudson Hudson added a comment - FAILURE: Integrated in HBase-1.3 #621 (See https://builds.apache.org/job/HBase-1.3/621/ ) HBASE-15520 Fix broken TestAsyncIPC (zhangduo: rev e07b662f9bc88ffff43b75bc870f76f771a64111) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncServerResponseHandler.java

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: