Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15497

Incorrect javadoc for atomicity guarantee of Increment and Append

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      At the front of Increment.java file, there is comment about read atomicity:

       * This operation does not appear atomic to readers.  Increments are done
       * under a single row lock, so write operations to a row are synchronized, but
       * readers do not take row locks so get and scan operations can see this
       * operation partially completed.
      

      It seems this comment is not true after MVCC integrated HBASE-4583. Currently, the readers can be guaranteed to read the whole result of Increment if I am not wrong. Similar comments also exist in Append.java, Table#append(...) and Table#increment(...)

      Attachments

        1. HBASE-15497-v1.patch
          5 kB
          Jianwei Cui

        Activity

          People

            cuijianwei Jianwei Cui
            cuijianwei Jianwei Cui
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: