Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15240 Go Big BucketCache Fixes
  3. HBASE-15386

PREFETCH_BLOCKS_ON_OPEN in HColumnDescriptor is ignored

    XMLWordPrintableJSON

Details

    • Hide
      This was a non-issue. The PREFETCH_... flag actually works. While here though made the following additions.

      Changes the prefetch TRACE-level loggings to include the word 'Prefetch' in them so you know what they are about.

      Changes the cryptic logging of the CacheConfig#toString to have some preamble saying why and what column family is responsible (helps figure what is going on)

      Add test that verifies setting flag on HColumnDescriptor actually works.
      Show
      This was a non-issue. The PREFETCH_... flag actually works. While here though made the following additions. Changes the prefetch TRACE-level loggings to include the word 'Prefetch' in them so you know what they are about. Changes the cryptic logging of the CacheConfig#toString to have some preamble saying why and what column family is responsible (helps figure what is going on) Add test that verifies setting flag on HColumnDescriptor actually works.

    Description

      We use the global flag hbase.rs.prefetchblocksonopen only and ignore the HCD setting.

      Purge from HCD or hook it up again (it probably worked once).

      Thanks to Daniel Pol for finding this one. Let me fix.

      Attachments

        1. 15386.patch
          6 kB
          Michael Stack
        2. 15386.branch-1.patch
          5 kB
          Michael Stack
        3. 15386.branch-1.2.patch
          5 kB
          Michael Stack
        4. 15386.branch-1.2.patch
          5 kB
          Michael Stack

        Activity

          People

            stack Michael Stack
            stack Michael Stack
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: