Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15240 Go Big BucketCache Fixes
  3. HBASE-15366

Add doc, trace-level logging, and test around hfileblock

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0.0
    • 1.3.0, 2.0.0
    • BlockCache
    • None
    • Reviewed
    • No functional change. Added javadoc, comments, and extra trace-level logging to make clear what is happening around the reading and caching of hfile blocks.

    Description

      What hfileblock is doing – that it overreads when pulling in from hdfs to fetch the header of the next block to save on seeks; that it caches the block and overread and then adds an extra 13 bytes to the cached entry; that buckets in bucketcache have at least four hfileblocks in them and so on – was totally baffling me. This patch docs the class, adds some trace-level logging so you can see if you are doing the right thing, and then adds a test of file-backed bucketcache that checks that persistence is working.

      Attachments

        1. 15366v4.patch
          89 kB
          Michael Stack
        2. 15366v4.patch
          89 kB
          Michael Stack
        3. 15366v3.patch
          89 kB
          Michael Stack
        4. 15366v2.patch
          90 kB
          Michael Stack
        5. 15366.patch
          90 kB
          Michael Stack
        6. 15366.branch-1.backport.patch
          87 kB
          Michael Stack
        7. 15355.backport.branch-1.v2.patch
          64 kB
          Michael Stack

        Activity

          People

            stack Michael Stack
            stack Michael Stack
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: