[HBASE-15274] ClientSideRegionScanner's reaction to Scan#setBatch is not consistent between HBase versions

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.3, 1.1.3, 0.98.17
• Fix Version/s: 1.0.4, 0.98.18
• Hadoop Flags: Reviewed
• Assignee: Youngjoon Kim
• Reporter: Youngjoon Kim
• Created: 16/Feb/16 13:09
• Updated: 18/Feb/16 17:20
• Resolved: 18/Feb/16 02:30

Description

In 1.1.3, ClientSideRegionScanner calls RegionScannerImpl#next() with single argument, so it honors Scan#setBatch(through defaultScannerContext in RegionScannerImpl).

// 1.1.3
public class ClientSideRegionScanner extends AbstractClientScanner {
  ...
  @Override
  public Result next() throws IOException {
    values.clear();
    scanner.nextRaw(values);
    ...

But in 1.0.3 and 0.98.17, ClientSideRegionScanner calls RegionScannerImpl#next() with limit=-1, so it ignores Scan#setBatch.

// 1.0.3 and 0.98.17
public class ClientSideRegionScanner extends AbstractClientScanner {
  ...
  @Override
  public Result next() throws IOException {
    values.clear();

    scanner.nextRaw(values, -1); // pass -1 as limit so that we see the whole row.
    ...