Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-14460 [Perf Regression] Merge of MVCC and SequenceId (HBASE-8763) slowed Increments, CheckAndPuts, batch operations
  3. HBASE-15224

Undo "hbase.increment.fast.but.narrow.consistency" option; it is not necessary since HBASE-15213

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.2.0, 1.3.0, 1.1.4, 1.0.4
    • Performance
    • None
    • Hide
      HBASE-15031 “Fix merge of MVCC and SequenceID performance regression in branch-1.0 for Increments” and HBASE-15091 ‘Forward-port to 1.2+ HBASE-15031 "Fix merge of MVCC and SequenceID performance regression in branch-1.0 for Increments"’ added a workaround ‘fast-path’ to restore an increment performance regression that came into hbase 1.0 when we unified mvcc and sequence id in HBASE-8763. The workaround became available in hbase-1.0.3 and hbase-1.1.3. The workaround involved setting the flag "hbase.increment.fast.but.narrow.consistency" in your configuration and restarting.

      Subsequently, the regression was fixed in HBASE-15213. The fix will be available in hbase-1.0.4 and hbase-1.1.4 when they are released. hbase-1.2.0 has the flag but as it turns out, it is not needed; there is no regression in 1.2.0.

      This issue removes the fast-path flag. If set, it will just be ignored.
      Show
      HBASE-15031 “Fix merge of MVCC and SequenceID performance regression in branch-1.0 for Increments” and HBASE-15091 ‘Forward-port to 1.2+ HBASE-15031 "Fix merge of MVCC and SequenceID performance regression in branch-1.0 for Increments"’ added a workaround ‘fast-path’ to restore an increment performance regression that came into hbase 1.0 when we unified mvcc and sequence id in HBASE-8763 . The workaround became available in hbase-1.0.3 and hbase-1.1.3. The workaround involved setting the flag "hbase.increment.fast.but.narrow.consistency" in your configuration and restarting. Subsequently, the regression was fixed in HBASE-15213 . The fix will be available in hbase-1.0.4 and hbase-1.1.4 when they are released. hbase-1.2.0 has the flag but as it turns out, it is not needed; there is no regression in 1.2.0. This issue removes the fast-path flag. If set, it will just be ignored.

    Description

      Remove an escape valve no longer needed after HBASE-15213. Remove so folks don't ever have to worry their pretty-little heads about it.

      Let the bulk of HBASE-15031 remain, the issue that added "hbase.increment.fast.but.narrow.consistency" because it mostly cleanup we want to keep.

      Attachments

        1. 0001-HBASE-15224-branch-1.2.patch
          21 kB
          Michael Stack
        2. 0001-HBASE-15224-Undo-hbase.increment.fast.branch-1.2.patch
          21 kB
          Michael Stack
        3. 15224.branch-1.2.addendum.patch
          4 kB
          Michael Stack
        4. 15224.branch-1.2.patch
          21 kB
          Michael Stack
        5. HBASE-15224.branch-1.2.patch
          21 kB
          Sean Busbey
        6. HBASE-15224v2-branch-1.2.patch
          21 kB
          Michael Stack

        Activity

          People

            stack Michael Stack
            stack Michael Stack
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: