[HBASE-15221] HTableMultiplexer improvements (stale region locations and resource leaks)

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.2.0, 1.3.0, 1.1.4, 2.0.0
• Component/s: Client
• Hadoop Flags: Reviewed
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 05/Feb/16 20:20
• Updated: 12/Feb/16 08:35
• Resolved: 12/Feb/16 04:48

Description

It looks like HTableMultiplexer has a couple of issues.

Upon failing to send a Put to the appropriate RS, the Put is re-queued back into the system. Normally this is fine as such an exception is transient and the Put would eventually succeed. However, in the case where the Put was rejected because of a NotServingRegionException (e.g. split, balance, merge), the re-queuing of the Put will end up using the same cached HRegionLocation. This means that the Put will just be repeatedly sent back to the same RS over and over again, eventually being dropped on the floor. Need to invalidate the location cache (or make sure we refresh it) when we re-queue the Put.

The internal ClusterConnection is also leaked. If a user creates many HTableMultiplexers, they'll eventually run into issues (memory, zk connections, etc) because they'll never get cleaned up. HTableMultiplexer needs a close method.

Issue Links

• duplicates: HBASE-12198 Fix the bug of not updating location cache

Sub-Tasks

• Exceptions returned over multi RPC don't automatically trigger region location reloads: Resolved