Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15177

Reduce garbage created under high load

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.3.0, 2.0.0
    • None
    • None
    • Reviewed

    Description

      I have been doing some profiling of the garbage being created. The idea was to follow up on HBASE-14490 and experiment with offheap IPC byte buffers and byte buffer re-use. However, without changing the IPC byte buffers for now, there are a couple of (easy) improvements that I've identified from profiling:

      1. RPCServer.Connection.processRequest() should work with ByteBuffer instead of byte[] and not-recreate CodedInputStream a few times.

      2. RSRpcServices.getRegion() allocates two byte arrays for region, while only 1 is needed.

      3. AnnotationReadingPriorityFunction is very expensive in allocations. Mainly it allocates the regionName byte[] to get the table name. We already set the priority for most of the operations (multi, get, increment, etc) but we are only reading the priority in case of multi. We should use the priority from the client side.

      Lets do the simple improvements in this patch, we can get to IPC buffer re-use in HBASE-14490.

      Attachments

        1. hbase-15177_v0.patch
          30 kB
          Enis Soztutar
        2. hbase-15177_v1.patch
          30 kB
          Enis Soztutar
        3. hbase-15177_v2.patch
          30 kB
          Enis Soztutar
        4. hbase-15177_v3.patch
          30 kB
          Enis Soztutar
        5. hbase-15177_v4.patch
          31 kB
          Enis Soztutar
        6. hbase-15177_v4.patch
          4 kB
          Enis Soztutar
        7. Screen Shot 2016-01-26 at 10.03.48 PM.png
          280 kB
          Enis Soztutar
        8. Screen Shot 2016-01-26 at 10.03.56 PM.png
          238 kB
          Enis Soztutar
        9. Screen Shot 2016-01-26 at 10.06.16 PM.png
          164 kB
          Enis Soztutar
        10. Screen Shot 2016-01-26 at 10.15.15 PM.png
          1.00 MB
          Enis Soztutar

        Activity

          People

            enis Enis Soztutar
            enis Enis Soztutar
            Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: