[HBASE-15117] Resolve ICAST findbugs warnings in current codes

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Yu Li
• Reporter: Yu Li
• Created: 15/Jan/16 03:20
• Updated: 21/Jan/16 04:11
• Resolved: 15/Jan/16 14:02

Description

In findbugs output of recent build, we could see ICAST warnings (Result of integer multiplication cast to long) on Compactor and ExportSnapshot

From the code I guess the design is to avoid multiplication result to overflow, however current implementation cannot achieve the goal. For example, output of below codes

int i = 1000000;
long a = i * i;
long b = (long) i * i;
System.out.println(a);
System.out.println(b);

will be

-727379968
1000000000000

Will make some minor changes to resolve this issue.

Issue Links

• Is contained by: HBASE-15118 Fix findbugs complaint in hbase-server