Details
Description
RSRpcServices#get updates the get metrics. However Multiactions do not.
Attachments
Attachments
- HBASE-15083-0.98.patch
- 2 kB
- Andrew Kyle Purtell
- HBASE-15083-branch-1.patch
- 2 kB
- Heng Chen
- HBASE-15083.patch
- 2 kB
- Heng Chen
- HBASE-15083.patch
- 2 kB
- Heng Chen
Activity
And i notice the metrics in doBatchOp is updated for the all mutations. Is it right?
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 0s | Docker mode activated. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
+1 | mvninstall | 2m 23s | master passed |
+1 | compile | 0m 31s | master passed with JDK v1.8.0_66 |
+1 | compile | 0m 34s | master passed with JDK v1.7.0_91 |
+1 | checkstyle | 4m 11s | master passed |
+1 | mvneclipse | 0m 16s | master passed |
-1 | findbugs | 1m 50s | hbase-server in master has 85 extant Findbugs warnings. |
+1 | javadoc | 0m 24s | master passed with JDK v1.8.0_66 |
+1 | javadoc | 0m 32s | master passed with JDK v1.7.0_91 |
+1 | mvninstall | 0m 44s | the patch passed |
+1 | compile | 0m 31s | the patch passed with JDK v1.8.0_66 |
+1 | javac | 0m 31s | the patch passed |
+1 | compile | 0m 33s | the patch passed with JDK v1.7.0_91 |
+1 | javac | 0m 33s | the patch passed |
+1 | checkstyle | 3m 55s | the patch passed |
+1 | mvneclipse | 0m 16s | the patch passed |
+1 | whitespace | 0m 0s | Patch has no whitespace issues. |
-1 | hadoopcheck | 1m 28s | Patch causes 11 errors with Hadoop v2.4.0. |
-1 | hadoopcheck | 2m 55s | Patch causes 11 errors with Hadoop v2.4.1. |
-1 | hadoopcheck | 4m 23s | Patch causes 11 errors with Hadoop v2.5.0. |
-1 | hadoopcheck | 5m 51s | Patch causes 11 errors with Hadoop v2.5.1. |
-1 | hadoopcheck | 7m 19s | Patch causes 11 errors with Hadoop v2.5.2. |
-1 | hadoopcheck | 8m 49s | Patch causes 11 errors with Hadoop v2.6.1. |
-1 | hadoopcheck | 10m 19s | Patch causes 11 errors with Hadoop v2.6.2. |
-1 | hadoopcheck | 11m 48s | Patch causes 11 errors with Hadoop v2.6.3. |
-1 | hadoopcheck | 13m 18s | Patch causes 11 errors with Hadoop v2.7.1. |
+1 | findbugs | 1m 59s | the patch passed |
+1 | javadoc | 0m 23s | the patch passed with JDK v1.8.0_66 |
+1 | javadoc | 0m 32s | the patch passed with JDK v1.7.0_91 |
+1 | unit | 81m 13s | hbase-server in the patch passed with JDK v1.8.0_66. |
-1 | unit | 81m 11s | hbase-server in the patch failed with JDK v1.7.0_91. |
+1 | asflicense | 0m 16s | Patch does not generate ASF License warnings. |
195m 57s |
Reason | Tests |
---|---|
JDK v1.7.0_91 Failed junit tests | hadoop.hbase.mapreduce.TestRowCounter |
Subsystem | Report/Notes |
---|---|
Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-01-11 |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12781487/HBASE-15083.patch |
JIRA Issue | |
Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile |
uname | Linux fb80ca7986e4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / c2f67a0 |
findbugs | v3.0.0 |
findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/51/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/51/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_91.txt |
unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/51/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_91.txt |
JDK v1.7.0_91 Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/51/testReport/ |
modules | C: hbase-server U: hbase-server |
Max memory used | 174MB |
Powered by | Apache Yetus 0.1.0 http://yetus.apache.org |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/51/console |
This message was automatically generated.
Hadoop check failed due to
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ hbase-assembly --- [ERROR] Error invoking method 'get(java.lang.Integer)' in java.util.ArrayList at META-INF/LICENSE.vm[line 1627, column 22] java.lang.reflect.InvocationTargetException at sun.reflect.GeneratedMethodAccessor138.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:395) at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:384) at org.apache.velocity.runtime.parser.node.ASTIndex.execute(ASTIndex.java:149) at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280) at org.apache.velocity.runtime.parser.node.ASTReference.evaluate(ASTReference.java:530) at org.apache.velocity.runtime.parser.node.ASTExpression.evaluate(ASTExpression.java:62) at org.apache.velocity.runtime.parser.node.ASTNotNode.evaluate(ASTNotNode.java:63) at org.apache.velocity.runtime.parser.node.ASTExpression.evaluate(ASTExpression.java:62) at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:85) at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72) at org.apache.velocity.runtime.directive.Foreach.render(Foreach.java:420) at org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207) at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72) at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87) at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342) at org.apache.velocity.Template.merge(Template.java:356) at org.apache.velocity.Template.merge(Template.java:260) at org.apache.velocity.app.VelocityEngine.mergeTemplate(VelocityEngine.java:354) at org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.processResourceBundles(ProcessRemoteResourcesMojo.java:1164) at org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.execute(ProcessRemoteResourcesMojo.java:520) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) Caused by: java.lang.IndexOutOfBoundsException: Index: 0, Size: 0 at java.util.ArrayList.rangeCheck(ArrayList.java:635) at java.util.ArrayList.get(ArrayList.java:411) ... 44 more
It has no relates with this patch. And java warnings will be fixed in HBASE-15086.
Failed testcase has no relates too.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 0s | Docker mode activated. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
+1 | mvninstall | 2m 33s | master passed |
+1 | compile | 0m 31s | master passed with JDK v1.8.0_66 |
+1 | compile | 0m 34s | master passed with JDK v1.7.0_91 |
+1 | checkstyle | 3m 57s | master passed |
+1 | mvneclipse | 0m 17s | master passed |
-1 | findbugs | 1m 51s | hbase-server in master has 84 extant Findbugs warnings. |
+1 | javadoc | 0m 23s | master passed with JDK v1.8.0_66 |
+1 | javadoc | 0m 34s | master passed with JDK v1.7.0_91 |
+1 | mvninstall | 0m 46s | the patch passed |
+1 | compile | 0m 30s | the patch passed with JDK v1.8.0_66 |
+1 | javac | 0m 30s | the patch passed |
+1 | compile | 0m 34s | the patch passed with JDK v1.7.0_91 |
+1 | javac | 0m 34s | the patch passed |
+1 | checkstyle | 4m 14s | the patch passed |
+1 | mvneclipse | 0m 18s | the patch passed |
+1 | whitespace | 0m 0s | Patch has no whitespace issues. |
+1 | hadoopcheck | 23m 1s | Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. |
+1 | findbugs | 2m 2s | the patch passed |
+1 | javadoc | 0m 32s | the patch passed with JDK v1.8.0_66 |
+1 | javadoc | 0m 35s | the patch passed with JDK v1.7.0_91 |
+1 | unit | 101m 29s | hbase-server in the patch passed with JDK v1.8.0_66. |
+1 | unit | 100m 25s | hbase-server in the patch passed with JDK v1.7.0_91. |
+1 | asflicense | 0m 16s | Patch does not generate ASF License warnings. |
245m 53s |
Subsystem | Report/Notes |
---|---|
Docker | Client=1.7.1 Server=1.7.1 Image:yetus/hbase:date2016-01-11 |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12781533/HBASE-15083.patch |
JIRA Issue | |
Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile |
uname | Linux d528952b7526 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 894ce84 |
findbugs | v3.0.0 |
findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/56/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html |
JDK v1.7.0_91 Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/56/testReport/ |
modules | C: hbase-server U: hbase-server |
Max memory used | 174MB |
Powered by | Apache Yetus 0.1.0 http://yetus.apache.org |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/56/console |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 0s | Docker mode activated. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
+1 | mvninstall | 2m 31s | master passed |
+1 | compile | 0m 41s | master passed with JDK v1.8.0_66 |
+1 | compile | 0m 34s | master passed with JDK v1.7.0_91 |
+1 | checkstyle | 4m 17s | master passed |
+1 | mvneclipse | 0m 16s | master passed |
-1 | findbugs | 1m 54s | hbase-server in master has 84 extant Findbugs warnings. |
+1 | javadoc | 0m 34s | master passed with JDK v1.8.0_66 |
+1 | javadoc | 0m 34s | master passed with JDK v1.7.0_91 |
+1 | mvninstall | 0m 48s | the patch passed |
+1 | compile | 0m 40s | the patch passed with JDK v1.8.0_66 |
+1 | javac | 0m 40s | the patch passed |
+1 | compile | 0m 37s | the patch passed with JDK v1.7.0_91 |
+1 | javac | 0m 37s | the patch passed |
+1 | checkstyle | 4m 11s | the patch passed |
+1 | mvneclipse | 0m 17s | the patch passed |
+1 | whitespace | 0m 0s | Patch has no whitespace issues. |
+1 | hadoopcheck | 22m 37s | Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. |
+1 | findbugs | 2m 13s | the patch passed |
+1 | javadoc | 0m 35s | the patch passed with JDK v1.8.0_66 |
+1 | javadoc | 0m 35s | the patch passed with JDK v1.7.0_91 |
-1 | unit | 113m 31s | hbase-server in the patch failed with JDK v1.8.0_66. |
-1 | unit | 106m 10s | hbase-server in the patch failed with JDK v1.7.0_91. |
+1 | asflicense | 0m 24s | Patch does not generate ASF License warnings. |
264m 32s |
Reason | Tests |
---|---|
JDK v1.8.0_66 Timed out junit tests | org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithClusters |
org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd | |
JDK v1.7.0_91 Failed junit tests | hadoop.hbase.mapreduce.TestSyncTable |
This message was automatically generated.
We should push this to other banches too if you are up for a backport. If not just let me know and I will.
SUCCESS: Integrated in HBase-1.2-IT #389 (See https://builds.apache.org/job/HBase-1.2-IT/389/)
HBASE-15083 Gets from Multiactions are not counted in metrics for gets (chenheng: rev c1d916d83fad74801a77de3d0e77aa8db721b85f)
- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
SUCCESS: Integrated in HBase-1.2 #500 (See https://builds.apache.org/job/HBase-1.2/500/)
HBASE-15083 Gets from Multiactions are not counted in metrics for gets (chenheng: rev c1d916d83fad74801a77de3d0e77aa8db721b85f)
- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
SUCCESS: Integrated in HBase-1.3 #491 (See https://builds.apache.org/job/HBase-1.3/491/)
HBASE-15083 Gets from Multiactions are not counted in metrics for gets (chenheng: rev 417e3c4a73a8efcc7a212b1cf77bee7a691cbe24)
- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
SUCCESS: Integrated in HBase-1.3-IT #433 (See https://builds.apache.org/job/HBase-1.3-IT/433/)
HBASE-15083 Gets from Multiactions are not counted in metrics for gets (chenheng: rev 417e3c4a73a8efcc7a212b1cf77bee7a691cbe24)
- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
FAILURE: Integrated in HBase-Trunk_matrix #627 (See https://builds.apache.org/job/HBase-Trunk_matrix/627/)
HBASE-15083 Gets from Multiactions are not counted in metrics for gets (chenheng: rev 8ee9158b5475b7d5bb6ba646420403820fac1d63)
- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
FAILURE: Integrated in HBase-1.1-JDK8 #1725 (See https://builds.apache.org/job/HBase-1.1-JDK8/1725/)
HBASE-15083 Gets from Multiactions are not counted in metrics for gets (chenheng: rev e6c094176aec0b28a7321471c214be55efc694a6)
- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
FAILURE: Integrated in HBase-1.1-JDK7 #1638 (See https://builds.apache.org/job/HBase-1.1-JDK7/1638/)
HBASE-15083 Gets from Multiactions are not counted in metrics for gets (chenheng: rev e6c094176aec0b28a7321471c214be55efc694a6)
- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
FAILURE: Integrated in HBase-1.0 #1133 (See https://builds.apache.org/job/HBase-1.0/1133/)
HBASE-15083 Gets from Multiactions are not counted in metrics for gets (chenheng: rev 556741b9ea031edadd982e098ee36ee88dd0df62)
- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
chenheng when committing, the Fix Version should be the next unrelease version on that release branch. For example, the next release of 1.1.x will be 1.1.3, so this fix for should be 1.1.3, not 1.1.0. I believe I've updated the field correctly, but please double-check.
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1189 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1189/)
HBASE-15083 Gets from Multiactions are not counted in metrics for gets (apurtell: rev 0e727de4d48298cb256db4074e8e95894c29eb49)
- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
ABORTED: Integrated in HBase-0.98-matrix #316 (See https://builds.apache.org/job/HBase-0.98-matrix/316/)
HBASE-15083 Gets from Multiactions are not counted in metrics for gets (apurtell: rev 0e727de4d48298cb256db4074e8e95894c29eb49)
- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
make a simple patch.