[HBASE-15046] Perf test doing all mutation steps under row lock

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: Performance

Release Note

In here we perf tested a realignment of the write pipeline and mvcc handling. Thought was that this work was a predicate for a general fix of HBASE-14460 (turns out, realignment of write path was not needed to fix the increment perf regression). The perf testing here made it so we were able to simplify writing. HBASE-15158 was just committed. This work is done.

• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 29/Dec/15 00:42
• Updated: 08/Feb/16 22:54
• Resolved: 08/Feb/16 17:58

Description

This issue is about perf testing a redo of the write pipeline so that rather than:

• take rowlock
• start mvcc
• append to WAL
• add to memstore
• sync WAL
• let go of rowlock
• finish up mvcc

instead.... try...

• take rowlock
• start mvcc
• append to WAL
• sync WAL
• add to memstore
• finish up mvcc
• let go of rowlock

The latter is more straight-forward undoing need of rolling back memstore if all does not succeed.

It might be slower though. This issue is a look-see/try it.

The redo will also help address the parent issue in a more general way so we can do without the special-casing done for branch-1.0 and branch-1.1 done in a sibling subtask.

Other benefits are that the current write pipeline is copy/pasted in a few places – in append, increment and checkand* – and a refactor will allow us to fix this duplication.