[HBASE-14997] Move compareOp and Comparators out of filter to client package

• Type: Sub-task
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.0.0-alpha-3, 2.0.0
• Hadoop Flags: Reviewed

Release Note

Deprecate checkAnd* APIs that take the filter CompareOp. Added new overrides that take a generic CompareOperator instead. CompareOperator will be used by checkAnd* in Table API and by filters going forward.

Other nice improvements suggested by this issue have been moved out to HBASE-18774.

• Assignee: Michael Stack
• Reporter: Enis Soztutar
• Created: 16/Dec/15 22:27
• Updated: 17/Jun/22 05:01
• Resolved: 07/Sep/17 21:22

Description

Table.checkAndPut() and its cousins depend on CompareOp from the filter package. Originally, ComparaOp and ByteArrayComparable, and various "comparators" have been used in filters, so these are in the filter package. However, for checkAndPut(), etc we depend on the filter subpackage although these are not filter related operations. We can use some clean up.

  boolean checkAndPut(byte[] row, byte[] family, byte[] qualifier,
    CompareFilter.CompareOp compareOp, byte[] value, Put put) throws IOException;

Some ideas

• Cleanup ByteArrayComparable interface (see the TODO at the class)
• Maybe introduce a Condition or a similar concept and do checkAndPut(Condition condition, Put put) and change filters to use that as well.
• Introducing Condition like thing will allow us to have an interface like: checkAndMutate(List<Condition> conditions, List<Mutation> mutations).
• BinaryComparator, etc are not "Comparators", they are comparables.

Issue Links

• is related to: HBASE-10390 expose checkAndPut/Delete custom comparators in HTable
• relates to: HBASE-18774 'Compare' API (checkAnd* and Filters) improvement
• links to: Review Board (master)