[HBASE-14902] Revert some of the stringency recently introduced by checkstyle tightening

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Hadoop Flags: Reviewed
• Release Note: Changes the checkstyle so that on a continuation line for javadoc, instead of default four spaces, instead now it is two spaces. Also one line statements as in if (true) x =1; now pass checkstyle.
• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 02/Dec/15 00:39
• Updated: 30/Jun/17 11:22
• Resolved: 30/Jun/17 11:22

Description

I think we should undo some of the plugins that were recently added to checkstyle. They are too much.

JavadocTagContinuationIndentationCheck is about adding indent if javadoc is two lines or more (javadoc tool doesn't care)

NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: e.g. @throws IOException needs to have text added.

NeedBracesCheck has us undoing cases where an if fits all on one line (don't want to start style wars but if short and fits on one line, I think its more readable... but I could relent on this one.... ).

The first two at least should go.

You ok w/ that appy