[HBASE-14811] HBaseInterClusterReplicationEndpoint retry logic is broken

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Duplicate
• Affects Version/s: 1.0.2, 1.2.0, 1.2.1, 0.98.16, 2.0.0
• Component/s: Replication
• Assignee: Unassigned
• Reporter: Ashu Pachauri
• Created: 13/Nov/15 21:01
• Updated: 23/Jun/22 20:02
• Resolved: 19/Nov/15 00:48

Description

In HBaseInterClusterReplicationEndpoint, we do something like this:

entryLists.remove(f.get());

where f.get() returns an ordinal number which represents the index of the element in the entryLists that just succeeded replicating. We remove these entries because we want to retry with remaining elements in the list in case of a failure. Since entryLists is an ArrayList, the subsequent elements are shifted left in case we remove an element. This breaks the intended functionality. The fix is to reverse sort the ordinals and then perform the deletion in one go.

Issue Links

• duplicates: HBASE-14777 Fix Inter Cluster Replication Future ordering issues