[HBASE-14784] Port conflict is not resolved in HBaseTestingUtility.randomFreePort()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.2
• Fix Version/s: 1.2.0, 1.3.0, 2.0.0
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Youngjoon Kim
• Reporter: Youngjoon Kim
• Created: 07/Nov/15 00:23
• Updated: 11/Nov/15 01:11
• Resolved: 10/Nov/15 19:55

Description

If takenRandomPorts.contains(port) == true, it means port conflict, so randomFreePort() should rerun the loop. But continue statement leads to exit the loop, because port != 0.

hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java

public static int randomFreePort() {
  int port = 0; 
  do { 
    port = randomPort();
    if (takenRandomPorts.contains(port)) {
      continue;
    }    
    takenRandomPorts.add(port);

    ...

  } while (port == 0);
  return port;
}