Details

    • Hadoop Flags:
      Reviewed

      Description

      While looking at the code I noticed that StoreScanner.optimize does not some unnecessary work. This is a very tight loop and even just looking up a reference can throw off the CPUs cache lines. This does safe a few percent of performance (not a lot, though).

      1. 14539-0.98.txt
        2 kB
        Lars Hofhansl

        Activity

        Hide
        ndimiduk Nick Dimiduk added a comment -

        Bulk closing 1.1.3 issues.

        Show
        ndimiduk Nick Dimiduk added a comment - Bulk closing 1.1.3 issues.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #1141 (See https://builds.apache.org/job/HBase-0.98/1141/)
        HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 458d36ff9c7175faa88d6afee4ff9afd099c6c1a)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #1141 (See https://builds.apache.org/job/HBase-0.98/1141/ ) HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 458d36ff9c7175faa88d6afee4ff9afd099c6c1a) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in HBase-1.3-IT #205 (See https://builds.apache.org/job/HBase-1.3-IT/205/)
        HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 5b3579c327184941bfa11501fc95f9fd33a3467f)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.3-IT #205 (See https://builds.apache.org/job/HBase-1.3-IT/205/ ) HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 5b3579c327184941bfa11501fc95f9fd33a3467f) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1094 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1094/)
        HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 458d36ff9c7175faa88d6afee4ff9afd099c6c1a)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1094 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1094/ ) HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 458d36ff9c7175faa88d6afee4ff9afd099c6c1a) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #6868 (See https://builds.apache.org/job/HBase-TRUNK/6868/)
        HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 3b8039ed0f687bd9a37303efd9aca63757183a09)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6868 (See https://builds.apache.org/job/HBase-TRUNK/6868/ ) HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 3b8039ed0f687bd9a37303efd9aca63757183a09) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-1.3 #229 (See https://builds.apache.org/job/HBase-1.3/229/)
        HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 5b3579c327184941bfa11501fc95f9fd33a3467f)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-1.3 #229 (See https://builds.apache.org/job/HBase-1.3/229/ ) HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 5b3579c327184941bfa11501fc95f9fd33a3467f) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-1.2 #222 (See https://builds.apache.org/job/HBase-1.2/222/)
        HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 18160cfe903cee72b9b4d2af402df4adc78f6eee)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-1.2 #222 (See https://builds.apache.org/job/HBase-1.2/222/ ) HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 18160cfe903cee72b9b4d2af402df4adc78f6eee) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in HBase-1.1 #693 (See https://builds.apache.org/job/HBase-1.1/693/)
        HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 31ef9b3bbae67e50cceacbc8fc9529ebf228d916)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.1 #693 (See https://builds.apache.org/job/HBase-1.1/693/ ) HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 31ef9b3bbae67e50cceacbc8fc9529ebf228d916) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in HBase-1.2-IT #185 (See https://builds.apache.org/job/HBase-1.2-IT/185/)
        HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 18160cfe903cee72b9b4d2af402df4adc78f6eee)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.2-IT #185 (See https://builds.apache.org/job/HBase-1.2-IT/185/ ) HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 18160cfe903cee72b9b4d2af402df4adc78f6eee) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-1.0 #1069 (See https://builds.apache.org/job/HBase-1.0/1069/)
        HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 866d88c3761bb2f2c009bfd5511c4db28f7a5570)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-1.0 #1069 (See https://builds.apache.org/job/HBase-1.0/1069/ ) HBASE-14539 Slight improvement of StoreScanner.optimize. (larsh: rev 866d88c3761bb2f2c009bfd5511c4db28f7a5570) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Committed to 0.98.x, 1.0.x, 1.1.x, 1.2.x, 1.3, and 2.0.

        Show
        lhofhansl Lars Hofhansl added a comment - Committed to 0.98.x, 1.0.x, 1.1.x, 1.2.x, 1.3, and 2.0.
        Hide
        lhofhansl Lars Hofhansl added a comment -

        I'll commit everywhere now.

        Show
        lhofhansl Lars Hofhansl added a comment - I'll commit everywhere now.
        Hide
        apurtell Andrew Purtell added a comment -

        +1

        I'm making a 0.98 release so will commit this patch for 0.98 just to that branch on the presumption the change will be committed to all branches as appropriate shortly.

        Show
        apurtell Andrew Purtell added a comment - +1 I'm making a 0.98 release so will commit this patch for 0.98 just to that branch on the presumption the change will be committed to all branches as appropriate shortly.
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Here's a trivial patch. Makes absolutely sure we do no work (other than the compares in the switch statements) unless we need to do any.

        I measured a 3-5% improvement in some cases.

        Trivial patch, no functional change. Will commit tomorrow unless I hear objections.

        Show
        lhofhansl Lars Hofhansl added a comment - Here's a trivial patch. Makes absolutely sure we do no work (other than the compares in the switch statements) unless we need to do any. I measured a 3-5% improvement in some cases. Trivial patch, no functional change. Will commit tomorrow unless I hear objections.

          People

          • Assignee:
            lhofhansl Lars Hofhansl
            Reporter:
            lhofhansl Lars Hofhansl
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development