Details

    • Hadoop Flags:
      Reviewed

      Description

      Right now every call gets a new User object.
      We should keep the same user for the life of a connection. We should also cache the group names. However we can't cache the groups for forever as that would mean groups don't get refreshed every 5 mins.

      1. HBASE-14512.patch
        9 kB
        Elliott Clark
      2. HBASE-14512-addendum-0.98.patch
        1 kB
        Andrew Purtell
      3. HBASE-14512-v1.patch
        10 kB
        Elliott Clark
      4. HBASE-14512-v2.patch
        14 kB
        Elliott Clark
      5. HBASE-14512-v3.patch
        14 kB
        Elliott Clark
      6. HBASE-14512-v4.patch
        14 kB
        Elliott Clark

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1161 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1161/)
          Amend HBASE-14512 Cache UGI groups (apurtell: rev d5f8300c082a75ce8edbbe08b66f077e7d663a4a)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1161 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1161/ ) Amend HBASE-14512 Cache UGI groups (apurtell: rev d5f8300c082a75ce8edbbe08b66f077e7d663a4a) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-matrix #287 (See https://builds.apache.org/job/HBase-0.98-matrix/287/)
          Amend HBASE-14512 Cache UGI groups (apurtell: rev d5f8300c082a75ce8edbbe08b66f077e7d663a4a)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-matrix #287 (See https://builds.apache.org/job/HBase-0.98-matrix/287/ ) Amend HBASE-14512 Cache UGI groups (apurtell: rev d5f8300c082a75ce8edbbe08b66f077e7d663a4a) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-Trunk_matrix #638 (See https://builds.apache.org/job/HBase-Trunk_matrix/638/)
          Amend HBASE-14512 Cache UGI groups (apurtell: rev 387eaff316d32b9983ecfff74520f6cb0e9b7404)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-Trunk_matrix #638 (See https://builds.apache.org/job/HBase-Trunk_matrix/638/ ) Amend HBASE-14512 Cache UGI groups (apurtell: rev 387eaff316d32b9983ecfff74520f6cb0e9b7404) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.2-IT #398 (See https://builds.apache.org/job/HBase-1.2-IT/398/)
          Amend HBASE-14512 Cache UGI groups (apurtell: rev b6dc3c5ae65d69ec97e619ef739bd0221ed1efb2)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.2-IT #398 (See https://builds.apache.org/job/HBase-1.2-IT/398/ ) Amend HBASE-14512 Cache UGI groups (apurtell: rev b6dc3c5ae65d69ec97e619ef739bd0221ed1efb2) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.3-IT #440 (See https://builds.apache.org/job/HBase-1.3-IT/440/)
          Amend HBASE-14512 Cache UGI groups (apurtell: rev 8272c84f60217f508165258b3f34e1f5c9d811db)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.3-IT #440 (See https://builds.apache.org/job/HBase-1.3-IT/440/ ) Amend HBASE-14512 Cache UGI groups (apurtell: rev 8272c84f60217f508165258b3f34e1f5c9d811db) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.3 #497 (See https://builds.apache.org/job/HBase-1.3/497/)
          Amend HBASE-14512 Cache UGI groups (apurtell: rev 8272c84f60217f508165258b3f34e1f5c9d811db)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.3 #497 (See https://builds.apache.org/job/HBase-1.3/497/ ) Amend HBASE-14512 Cache UGI groups (apurtell: rev 8272c84f60217f508165258b3f34e1f5c9d811db) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.2 #507 (See https://builds.apache.org/job/HBase-1.2/507/)
          Amend HBASE-14512 Cache UGI groups (apurtell: rev b6dc3c5ae65d69ec97e619ef739bd0221ed1efb2)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.2 #507 (See https://builds.apache.org/job/HBase-1.2/507/ ) Amend HBASE-14512 Cache UGI groups (apurtell: rev b6dc3c5ae65d69ec97e619ef739bd0221ed1efb2) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Hide
          apurtell Andrew Purtell added a comment -

          Committed the addendum to 0.98, branch-1.2, branch-1, and master

          Show
          apurtell Andrew Purtell added a comment - Committed the addendum to 0.98, branch-1.2, branch-1, and master
          Hide
          apurtell Andrew Purtell added a comment -

          Addendum adds a null check for 'connection' when constructing a RpcServer#Call. Patch based on 0.98 but the change is the same everywhere.

          Show
          apurtell Andrew Purtell added a comment - Addendum adds a null check for 'connection' when constructing a RpcServer#Call. Patch based on 0.98 but the change is the same everywhere.
          Hide
          apurtell Andrew Purtell added a comment -

          This change will cause Phoenix's PhoenixIndexRpcSchedulerTest to fail with a NPE. There is something very simple (and correct) we can do as an addendum to fix it. Attaching the addendum. Unless objection will commit the addendum to all branches that have this change shortly, to get the 0.98 RC out the door.

          Show
          apurtell Andrew Purtell added a comment - This change will cause Phoenix's PhoenixIndexRpcSchedulerTest to fail with a NPE. There is something very simple (and correct) we can do as an addendum to fix it. Attaching the addendum. Unless objection will commit the addendum to all branches that have this change shortly, to get the 0.98 RC out the door.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-matrix #262 (See https://builds.apache.org/job/HBase-0.98-matrix/262/)
          Amend HBASE-14512 Cache UGI groups (apurtell: rev 474c39913738db8a9a7358052e581279b081e471)

          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-matrix #262 (See https://builds.apache.org/job/HBase-0.98-matrix/262/ ) Amend HBASE-14512 Cache UGI groups (apurtell: rev 474c39913738db8a9a7358052e581279b081e471) hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1135 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1135/)
          Amend HBASE-14512 Cache UGI groups (apurtell: rev 474c39913738db8a9a7358052e581279b081e471)

          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1135 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1135/ ) Amend HBASE-14512 Cache UGI groups (apurtell: rev 474c39913738db8a9a7358052e581279b081e471) hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-matrix #259 (See https://builds.apache.org/job/HBase-0.98-matrix/259/)
          HBASE-14512 Cache UGI groups (apurtell: rev 8d94773044a68ba601eecd4a08b02c48df5cbaa7)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-matrix #259 (See https://builds.apache.org/job/HBase-0.98-matrix/259/ ) HBASE-14512 Cache UGI groups (apurtell: rev 8d94773044a68ba601eecd4a08b02c48df5cbaa7) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1132 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1132/)
          HBASE-14512 Cache UGI groups (apurtell: rev 8d94773044a68ba601eecd4a08b02c48df5cbaa7)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1132 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1132/ ) HBASE-14512 Cache UGI groups (apurtell: rev 8d94773044a68ba601eecd4a08b02c48df5cbaa7) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.2 #214 (See https://builds.apache.org/job/HBase-1.2/214/)
          HBASE-14512 Cache UGI groups (eclark: rev 54b64871fff96b35302f4709154eca6aa2699cf7)

          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.2 #214 (See https://builds.apache.org/job/HBase-1.2/214/ ) HBASE-14512 Cache UGI groups (eclark: rev 54b64871fff96b35302f4709154eca6aa2699cf7) hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.3 #220 (See https://builds.apache.org/job/HBase-1.3/220/)
          HBASE-14512 Cache UGI groups (eclark: rev cca2ba4d93d8e476bed3e82631a165cb674fb682)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.3 #220 (See https://builds.apache.org/job/HBase-1.3/220/ ) HBASE-14512 Cache UGI groups (eclark: rev cca2ba4d93d8e476bed3e82631a165cb674fb682) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #6860 (See https://builds.apache.org/job/HBase-TRUNK/6860/)
          HBASE-14512 Cache UGI groups (eclark: rev a463984945717bf9cb2881c3d586d5b11d192d65)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6860 (See https://builds.apache.org/job/HBase-TRUNK/6860/ ) HBASE-14512 Cache UGI groups (eclark: rev a463984945717bf9cb2881c3d586d5b11d192d65) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.2-IT #179 (See https://builds.apache.org/job/HBase-1.2-IT/179/)
          HBASE-14512 Cache UGI groups (eclark: rev 54b64871fff96b35302f4709154eca6aa2699cf7)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.2-IT #179 (See https://builds.apache.org/job/HBase-1.2-IT/179/ ) HBASE-14512 Cache UGI groups (eclark: rev 54b64871fff96b35302f4709154eca6aa2699cf7) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.3-IT #195 (See https://builds.apache.org/job/HBase-1.3-IT/195/)
          HBASE-14512 Cache UGI groups (eclark: rev cca2ba4d93d8e476bed3e82631a165cb674fb682)

          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.3-IT #195 (See https://builds.apache.org/job/HBase-1.3-IT/195/ ) HBASE-14512 Cache UGI groups (eclark: rev cca2ba4d93d8e476bed3e82631a165cb674fb682) hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
          Hide
          eclark Elliott Clark added a comment -

          Thanks for the review. Pushed to branch-1.2+

          Show
          eclark Elliott Clark added a comment - Thanks for the review. Pushed to branch-1.2+
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12764433/HBASE-14512-v4.patch
          against master branch at commit 24370547c500df0026a71944d8be88cd5b51b23e.
          ATTACHMENT ID: 12764433

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          -1 core zombie tests. There are 1 zombie test(s):

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15830//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15830//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15830//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15830//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12764433/HBASE-14512-v4.patch against master branch at commit 24370547c500df0026a71944d8be88cd5b51b23e. ATTACHMENT ID: 12764433 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15830//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15830//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15830//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15830//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12764357/HBASE-14512-v3.patch
          against master branch at commit c04d18970e066c1c5879a7ac1d261ef69cae5c3e.
          ATTACHMENT ID: 12764357

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.security.TestSecureRPC
          org.apache.hadoop.hbase.regionserver.TestRegionMergeTransaction
          org.apache.hadoop.hbase.procedure.TestProcedureManager
          org.apache.hadoop.hbase.ipc.TestAsyncIPC
          org.apache.hadoop.hbase.ipc.TestIPC
          org.apache.hadoop.hbase.mob.mapreduce.TestMobSweepMapper
          org.apache.hadoop.hbase.mapred.TestRowCounter
          org.apache.hadoop.hbase.mapreduce.TestTableMapReduceUtil
          org.apache.hadoop.hbase.ipc.TestRpcClientLeaks

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15819//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15819//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15819//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15819//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12764357/HBASE-14512-v3.patch against master branch at commit c04d18970e066c1c5879a7ac1d261ef69cae5c3e. ATTACHMENT ID: 12764357 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.security.TestSecureRPC org.apache.hadoop.hbase.regionserver.TestRegionMergeTransaction org.apache.hadoop.hbase.procedure.TestProcedureManager org.apache.hadoop.hbase.ipc.TestAsyncIPC org.apache.hadoop.hbase.ipc.TestIPC org.apache.hadoop.hbase.mob.mapreduce.TestMobSweepMapper org.apache.hadoop.hbase.mapred.TestRowCounter org.apache.hadoop.hbase.mapreduce.TestTableMapReduceUtil org.apache.hadoop.hbase.ipc.TestRpcClientLeaks Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15819//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15819//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15819//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15819//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12764349/HBASE-14512-v2.patch
          against master branch at commit c04d18970e066c1c5879a7ac1d261ef69cae5c3e.
          ATTACHMENT ID: 12764349

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.security.TestSecureRPC
          org.apache.hadoop.hbase.mapred.TestRowCounter
          org.apache.hadoop.hbase.mapreduce.TestTableMapReduceUtil
          org.apache.hadoop.hbase.procedure.TestProcedureManager
          org.apache.hadoop.hbase.ipc.TestRpcClientLeaks
          org.apache.hadoop.hbase.ipc.TestIPC
          org.apache.hadoop.hbase.mob.mapreduce.TestMobSweepMapper
          org.apache.hadoop.hbase.regionserver.TestRegionMergeTransaction
          org.apache.hadoop.hbase.ipc.TestAsyncIPC

          -1 core zombie tests. There are 1 zombie test(s):

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15816//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15816//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15816//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15816//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12764349/HBASE-14512-v2.patch against master branch at commit c04d18970e066c1c5879a7ac1d261ef69cae5c3e. ATTACHMENT ID: 12764349 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.security.TestSecureRPC org.apache.hadoop.hbase.mapred.TestRowCounter org.apache.hadoop.hbase.mapreduce.TestTableMapReduceUtil org.apache.hadoop.hbase.procedure.TestProcedureManager org.apache.hadoop.hbase.ipc.TestRpcClientLeaks org.apache.hadoop.hbase.ipc.TestIPC org.apache.hadoop.hbase.mob.mapreduce.TestMobSweepMapper org.apache.hadoop.hbase.regionserver.TestRegionMergeTransaction org.apache.hadoop.hbase.ipc.TestAsyncIPC -1 core zombie tests . There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15816//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15816//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15816//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15816//console This message is automatically generated.
          Hide
          ghelmling Gary Helmling added a comment -

          +1 from me on v3.

          Show
          ghelmling Gary Helmling added a comment - +1 from me on v3.
          Hide
          eclark Elliott Clark added a comment -

          Code comments on phab and make the thread static.

          Show
          eclark Elliott Clark added a comment - Code comments on phab and make the thread static.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12764322/HBASE-14512-v1.patch
          against master branch at commit 653458365281d96c288804d094c7d5f8d826a7d7.
          ATTACHMENT ID: 12764322

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          -1 core zombie tests. There are 1 zombie test(s): at org.apache.tajo.jdbc.TestTajoJdbcNegative.testConnectTimeout(TestTajoJdbcNegative.java:226)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15812//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15812//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15812//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15812//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12764322/HBASE-14512-v1.patch against master branch at commit 653458365281d96c288804d094c7d5f8d826a7d7. ATTACHMENT ID: 12764322 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . -1 core zombie tests . There are 1 zombie test(s): at org.apache.tajo.jdbc.TestTajoJdbcNegative.testConnectTimeout(TestTajoJdbcNegative.java:226) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15812//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15812//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15812//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15812//console This message is automatically generated.
          Hide
          eclark Elliott Clark added a comment -

          Patch that cleans up the caching and make the refreshing of groups happen in a background thread.

          Show
          eclark Elliott Clark added a comment - Patch that cleans up the caching and make the refreshing of groups happen in a background thread.
          Show
          eclark Elliott Clark added a comment - https://reviews.facebook.net/D47751
          Hide
          eclark Elliott Clark added a comment -

          Add on more comments about why numbers were choosen

          Show
          eclark Elliott Clark added a comment - Add on more comments about why numbers were choosen
          Hide
          eclark Elliott Clark added a comment -
          Show
          eclark Elliott Clark added a comment - cc Gary Helmling

            People

            • Assignee:
              eclark Elliott Clark
              Reporter:
              eclark Elliott Clark
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development