[HBASE-14449] Rewrite deadlock prevention for concurrent connection close

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0, 1.3.0, 1.0.3, 1.1.3, 2.0.0
• Component/s: master, metrics
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 18/Sep/15 15:24
• Updated: 16/Aug/17 05:09
• Resolved: 19/Sep/15 00:34

Description

The deadlock prevention approach used in HBASE-14241 introduces unnecessary logic which is not intuitive.

Depending on the value for config hbase.ipc.client.specificThreadForWriting , there may or may not be CallSender threads running.

The attached patch simplifies deadlock prevention by using a Set which represents the Connections to be closed. Outside the synchronized (connections) block, this Set is iterated where the Connections are closed.