Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-14317 Stuck FSHLog: bad disk (HDFS-8960) and can't roll WAL
  3. HBASE-14401

Stamp failed appends with sequenceid too.... Cleans up latches

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.2.0, 1.3.0, 2.0.0
    • test, wal
    • None
    • Reviewed

    Description

      Looking in test output I see we can sometimes get stuck waiting on sequenceid... The parent issues redo of our semantic makes it so we encounter failed append more often around damaged WAL.

      This patch makes it so we stamp sequenceid always, even if the append fails. This way all sequenceids are accounted for but more important, the latch on sequenceid down in WALKey will be cleared.. where before it was not being cleared (there is no global list of outstanding WALKeys waiting on sequenceids so no way to clean them up... we don't need such a list if we ALWAYS stamp the sequenceid).

      Attachments

        1. 14401.txt
          4 kB
          Michael Stack
        2. 14401.v7.txt
          13 kB
          Michael Stack
        3. 14401.v7.txt
          13 kB
          Michael Stack
        4. 14401.v7.txt
          13 kB
          Michael Stack
        5. 14401v3.txt
          5 kB
          Michael Stack
        6. 14401v3.txt
          5 kB
          Michael Stack
        7. 14401v3.txt
          5 kB
          Michael Stack
        8. 14401v6.txt
          7 kB
          Michael Stack

        Activity

          People

            stack Michael Stack
            stack Michael Stack
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: