[HBASE-14392] [tests] TestLogRollingNoCluster fails on master from time to time

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0, 1.3.0, 2.0.0
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 09/Sep/15 17:17
• Updated: 01/Jul/22 21:23
• Resolved: 11/Sep/15 03:28

Description

TestLogRollingNoCluster fails from time to time on a rig I have running here.

Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
Running org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.155 sec - in org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

The test itself is a bit odd. We apparently have seen NPEs around close of a WAL while trying to sync... which I suppose makes sense if two threads involved.

Attached patch just fails the sync silently if stream is null... lets presume it a close. Adds a sync on write of trailer too...

This patch seems to have gotten rid of the odd failure seen on a particular box here if I keep cycling the test.