Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-14258

Make region_mover.rb script case insensitive with regard to hostname

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.2.0, 1.3.0, 0.98.15, 1.1.3, 2.0.0
    • None
    • None
    • Reviewed

    Description

      The script is case sensitive and fails when case of a host name being unloaded does not match with a case of a region server name returned by HBase API.

      This doc clarifies IETF rules on case insensitivities in DNS:
      https://www.ietf.org/rfc/rfc4343.txt

      Attachments

        1. 14258-addendum.2
          0.7 kB
          Ted Yu
        2. HBASE-14258.patch
          0.8 kB
          Vladimir Rodionov
        3. HBASE-14258.patch.add
          0.6 kB
          Vladimir Rodionov

        Activity

          Patch for master.

          vrodionov Vladimir Rodionov added a comment - Patch for master.
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12751317/HBASE-14258.patch
          against master branch at commit 16f8d277088987dc8d4bb1614d05ce712bfc245d.
          ATTACHMENT ID: 12751317

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation, build,
          or dev-support patch that doesn't require tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover

          -1 core zombie tests. There are 9 zombie test(s): at org.apache.hadoop.hbase.client.TestAdmin1.testSplitAndMergeWithReplicaTable(TestAdmin1.java:1179)
          at org.apache.hadoop.hbase.client.TestFromClientSide.testIllegalTableDescriptor(TestFromClientSide.java:5550)
          at org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithClusters.testEnableReplicationWhenSlaveClusterDoesntHaveTable(TestReplicationAdminWithClusters.java:65)
          at org.apache.hadoop.hbase.client.TestTableSnapshotScanner.testScanner(TestTableSnapshotScanner.java:136)
          at org.apache.hadoop.hbase.client.TestTableSnapshotScanner.testWithOfflineHBaseMultiRegion(TestTableSnapshotScanner.java:125)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15171//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15171//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15171//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15171//console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12751317/HBASE-14258.patch against master branch at commit 16f8d277088987dc8d4bb1614d05ce712bfc245d. ATTACHMENT ID: 12751317 +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation, build, or dev-support patch that doesn't require tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover -1 core zombie tests . There are 9 zombie test(s): at org.apache.hadoop.hbase.client.TestAdmin1.testSplitAndMergeWithReplicaTable(TestAdmin1.java:1179) at org.apache.hadoop.hbase.client.TestFromClientSide.testIllegalTableDescriptor(TestFromClientSide.java:5550) at org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithClusters.testEnableReplicationWhenSlaveClusterDoesntHaveTable(TestReplicationAdminWithClusters.java:65) at org.apache.hadoop.hbase.client.TestTableSnapshotScanner.testScanner(TestTableSnapshotScanner.java:136) at org.apache.hadoop.hbase.client.TestTableSnapshotScanner.testWithOfflineHBaseMultiRegion(TestTableSnapshotScanner.java:125) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15171//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15171//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15171//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15171//console This message is automatically generated.
          ddas Devaraj Das added a comment -

          +1

          ddas Devaraj Das added a comment - +1

          +1 LGTM

          syuanjiang Stephen Yuan Jiang added a comment - +1 LGTM
          yuzhihong@gmail.com Ted Yu added a comment -

          Thanks for the patch, Vlad.

          yuzhihong@gmail.com Ted Yu added a comment - Thanks for the patch, Vlad.
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.2-IT #113 (See https://builds.apache.org/job/HBase-1.2-IT/113/)
          HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (tedyu: rev 268a69f17b6f63713f68080cee7bfafc9e58293f)

          • bin/region_mover.rb
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.2-IT #113 (See https://builds.apache.org/job/HBase-1.2-IT/113/ ) HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (tedyu: rev 268a69f17b6f63713f68080cee7bfafc9e58293f) bin/region_mover.rb
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.3-IT #116 (See https://builds.apache.org/job/HBase-1.3-IT/116/)
          HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (tedyu: rev 9b55f1cd293c5165d6d12c88542297c093cad3d9)

          • bin/region_mover.rb
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.3-IT #116 (See https://builds.apache.org/job/HBase-1.3-IT/116/ ) HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (tedyu: rev 9b55f1cd293c5165d6d12c88542297c093cad3d9) bin/region_mover.rb
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.2 #137 (See https://builds.apache.org/job/HBase-1.2/137/)
          HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (tedyu: rev 268a69f17b6f63713f68080cee7bfafc9e58293f)

          • bin/region_mover.rb
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.2 #137 (See https://builds.apache.org/job/HBase-1.2/137/ ) HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (tedyu: rev 268a69f17b6f63713f68080cee7bfafc9e58293f) bin/region_mover.rb
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.1 #637 (See https://builds.apache.org/job/HBase-1.1/637/)
          HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (tedyu: rev ae543905127bd09c35c11b7e9aa5d8cb368b3c46)

          • bin/region_mover.rb
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.1 #637 (See https://builds.apache.org/job/HBase-1.1/637/ ) HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (tedyu: rev ae543905127bd09c35c11b7e9aa5d8cb368b3c46) bin/region_mover.rb
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.3 #135 (See https://builds.apache.org/job/HBase-1.3/135/)
          HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (tedyu: rev 9b55f1cd293c5165d6d12c88542297c093cad3d9)

          • bin/region_mover.rb
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.3 #135 (See https://builds.apache.org/job/HBase-1.3/135/ ) HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (tedyu: rev 9b55f1cd293c5165d6d12c88542297c093cad3d9) bin/region_mover.rb
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #6756 (See https://builds.apache.org/job/HBase-TRUNK/6756/)
          HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (tedyu: rev 506726ed2832b069602c6b7e2ccd5ec9a81013a6)

          • bin/region_mover.rb
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6756 (See https://builds.apache.org/job/HBase-TRUNK/6756/ ) HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (tedyu: rev 506726ed2832b069602c6b7e2ccd5ec9a81013a6) bin/region_mover.rb

          Reopening to push additional patch.

          vrodionov Vladimir Rodionov added a comment - Reopening to push additional patch.

          Addendum fixes case sensitivity in 'load'

          vrodionov Vladimir Rodionov added a comment - Addendum fixes case sensitivity in 'load'

          tedyu@apache.org, addendum to the original patch that fixes case sensitivity in 'load' method.

          vrodionov Vladimir Rodionov added a comment - tedyu@apache.org , addendum to the original patch that fixes case sensitivity in 'load' method.
          yuzhihong@gmail.com Ted Yu added a comment -
          +    if hostFromServerName == hostname.upcase and portFromServerName == port
          

          Uppcasing hostname can be done outside the loop, right ?

          yuzhihong@gmail.com Ted Yu added a comment - + if hostFromServerName == hostname.upcase and portFromServerName == port Uppcasing hostname can be done outside the loop, right ?

          This is not a critical loop, Ted. Sure it can but we need to introduce new variable.

          vrodionov Vladimir Rodionov added a comment - This is not a critical loop, Ted. Sure it can but we need to introduce new variable.
          yuzhihong@gmail.com Ted Yu added a comment -

          @Vlad:
          If you agree with the formation in addendum 2, I can commit it.

          yuzhihong@gmail.com Ted Yu added a comment - @Vlad: If you agree with the formation in addendum 2, I can commit it.

          Sure, go ahead, Ted.

          vrodionov Vladimir Rodionov added a comment - Sure, go ahead, Ted.
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.1 #642 (See https://builds.apache.org/job/HBase-1.1/642/)
          HBASE-14258 Addendum fixes case sensitivity in 'load' (Vladimir Rodionov) (tedyu: rev 5532af9727be3dd163056292948a0deddb56ccac)

          • bin/region_mover.rb
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.1 #642 (See https://builds.apache.org/job/HBase-1.1/642/ ) HBASE-14258 Addendum fixes case sensitivity in 'load' (Vladimir Rodionov) (tedyu: rev 5532af9727be3dd163056292948a0deddb56ccac) bin/region_mover.rb
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.3 #140 (See https://builds.apache.org/job/HBase-1.3/140/)
          HBASE-14258 Addendum fixes case sensitivity in 'load' (Vladimir Rodionov) (tedyu: rev 861d546b873dedc1cd8703c9daf623ba83f83d1a)

          • bin/region_mover.rb
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.3 #140 (See https://builds.apache.org/job/HBase-1.3/140/ ) HBASE-14258 Addendum fixes case sensitivity in 'load' (Vladimir Rodionov) (tedyu: rev 861d546b873dedc1cd8703c9daf623ba83f83d1a) bin/region_mover.rb
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.2 #144 (See https://builds.apache.org/job/HBase-1.2/144/)
          HBASE-14258 Addendum fixes case sensitivity in 'load' (Vladimir Rodionov) (tedyu: rev 1ca1409a36495605d1c8c30b55b625533244c470)

          • bin/region_mover.rb
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.2 #144 (See https://builds.apache.org/job/HBase-1.2/144/ ) HBASE-14258 Addendum fixes case sensitivity in 'load' (Vladimir Rodionov) (tedyu: rev 1ca1409a36495605d1c8c30b55b625533244c470) bin/region_mover.rb
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #6765 (See https://builds.apache.org/job/HBase-TRUNK/6765/)
          HBASE-14258 Addendum fixes case sensitivity in 'load' (Vladimir Rodionov) (tedyu: rev 4256128fa248b31c0482bdfc2510011771f84037)

          • bin/region_mover.rb
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6765 (See https://builds.apache.org/job/HBase-TRUNK/6765/ ) HBASE-14258 Addendum fixes case sensitivity in 'load' (Vladimir Rodionov) (tedyu: rev 4256128fa248b31c0482bdfc2510011771f84037) bin/region_mover.rb
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.2-IT #120 (See https://builds.apache.org/job/HBase-1.2-IT/120/)
          HBASE-14258 Addendum fixes case sensitivity in 'load' (Vladimir Rodionov) (tedyu: rev 1ca1409a36495605d1c8c30b55b625533244c470)

          • bin/region_mover.rb
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.2-IT #120 (See https://builds.apache.org/job/HBase-1.2-IT/120/ ) HBASE-14258 Addendum fixes case sensitivity in 'load' (Vladimir Rodionov) (tedyu: rev 1ca1409a36495605d1c8c30b55b625533244c470) bin/region_mover.rb
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.3-IT #122 (See https://builds.apache.org/job/HBase-1.3-IT/122/)
          HBASE-14258 Addendum fixes case sensitivity in 'load' (Vladimir Rodionov) (tedyu: rev 861d546b873dedc1cd8703c9daf623ba83f83d1a)

          • bin/region_mover.rb
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.3-IT #122 (See https://builds.apache.org/job/HBase-1.3-IT/122/ ) HBASE-14258 Addendum fixes case sensitivity in 'load' (Vladimir Rodionov) (tedyu: rev 861d546b873dedc1cd8703c9daf623ba83f83d1a) bin/region_mover.rb
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98 #1112 (See https://builds.apache.org/job/HBase-0.98/1112/)
          HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (apurtell: rev bcfb91d4e453780d2191d14b2a9d364360a660dd)

          • bin/region_mover.rb
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98 #1112 (See https://builds.apache.org/job/HBase-0.98/1112/ ) HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (apurtell: rev bcfb91d4e453780d2191d14b2a9d364360a660dd) bin/region_mover.rb
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1065 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1065/)
          HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (apurtell: rev bcfb91d4e453780d2191d14b2a9d364360a660dd)

          • bin/region_mover.rb
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1065 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1065/ ) HBASE-14258 Make region_mover.rb script case insensitive with regard to hostname (Vladimir Rodionov) (apurtell: rev bcfb91d4e453780d2191d14b2a9d364360a660dd) bin/region_mover.rb
          ndimiduk Nick Dimiduk added a comment -

          Bulk closing 1.1.3 issues.

          ndimiduk Nick Dimiduk added a comment - Bulk closing 1.1.3 issues.

          People

            vrodionov Vladimir Rodionov
            vrodionov Vladimir Rodionov
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: