[HBASE-14256] Flush task message may be confusing when region is recovered

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0, 2.0.0
• Fix Version/s: 1.3.0, 1.2.1, 2.0.0
• Component/s: regionserver
• Labels: beginner
• Hadoop Flags: Reviewed
• Release Note: HBASE-14256 Correct confusing flush task message
• Assignee: Gabor Liptak
• Reporter: Lars George
• Created: 19/Aug/15 15:43
• Updated: 01/Jul/22 20:58
• Resolved: 24/Mar/16 17:16

Description

In HRegion.setRecovering() we have this code:

    // force a flush only if region replication is set up for this region. Otherwise no need.
      boolean forceFlush = getTableDesc().getRegionReplication() > 1;

      // force a flush first
      MonitoredTask status = TaskMonitor.get().createStatus(
        "Flushing region " + this + " because recovery is finished");
      try {
        if (forceFlush) {
          internalFlushcache(status);
        }

So we only optionally force flush after a recovery of a region, but the message always is set to "Flushing...", which might be confusing. We should change the message based on forceFlush.