[HBASE-14115] Fix resource leak in HMasterCommandLine

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0, 1.3.0, 2.0.0
• Fix Version/s: 1.2.0, 1.3.0, 2.0.0
• Component/s: master, tooling
• Hadoop Flags: Reviewed
• Assignee: Yuhao Bi
• Reporter: Yuhao Bi
• Created: 17/Jul/15 07:52
• Updated: 01/Jul/22 20:45
• Resolved: 22/Jul/15 13:01

Description

In HMasterCommandLine#stopMaster(), admin is not closed.

HMasterCommandLine.java

try (Connection connection = ConnectionFactory.createConnection(conf)) {
      try (Admin admin = connection.getAdmin()) {
        connection.getAdmin().shutdown();
      } catch (Throwable t) {
        LOG.error("Failed to stop master", t);
        return 1;
      }
    }