[HBASE-13974] TestRateLimiter#testFixedIntervalResourceAvailability may fail

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 1.2.0, 1.1.2, 1.3.0, 2.0.0
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Guanghao Zhang
• Reporter: Guanghao Zhang
• Created: 26/Jun/15 01:56
• Updated: 01/Jul/22 20:18
• Resolved: 26/Jun/15 15:27

Description

Stacktrace

java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at org.junit.Assert.assertFalse(Assert.java:74)
at org.apache.hadoop.hbase.quotas.TestRateLimiter.testFixedIntervalResourceAvailability(TestRateLimiter.java:151)

The code of this ut.

     RateLimiter limiter = new FixedIntervalRateLimiter();
     limiter.set(10, TimeUnit.MILLISECONDS);
 
     assertTrue(limiter.canExecute(10));
     limiter.consume(3);
     assertEquals(7, limiter.getAvailable());
     assertFalse(limiter.canExecute(10));

The limiter will refill by MILLISECONDS. So if this unit test execute slowly or hang by others over 1 ms, the assertFalse(limiter.canExecute(10)) will fail.