Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13941

Backport HBASE-13917 (Remove string comparison to identify request priority) to release branches

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.0.2, 1.1.2
    • None
    • None

    Description

      Backport HBASE-13917 (Remove string comparison to identify request priority) to release branches.

      Attachments

        1. HBASE-13941-branch-1.0.patch
          7 kB
          Andrew Kyle Purtell

        Issue Links

          Activity

            As discussed on HBASE-13917 it's been a few weeks so proceeding with the backport

            apurtell Andrew Kyle Purtell added a comment - As discussed on HBASE-13917 it's been a few weeks so proceeding with the backport

            Patch for branch-1.0 and branch-1.1 attached

            apurtell Andrew Kyle Purtell added a comment - Patch for branch-1.0 and branch-1.1 attached
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org
            against master branch at commit 4dd30ab019cfbf3691fd08f7941d33d8bbc37f05.
            ATTACHMENT ID: http:

            +1 @author. The patch does not contain any @author tags.

            +0 tests included. The patch appears to be a documentation, build,
            or dev-support patch that doesn't require tests.

            -1 patch. The patch command could not apply the patch.

            Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15091//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org against master branch at commit 4dd30ab019cfbf3691fd08f7941d33d8bbc37f05. ATTACHMENT ID: http: +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation, build, or dev-support patch that doesn't require tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15091//console This message is automatically generated.

            Attached rebased patch, let's try again.

            apurtell Andrew Kyle Purtell added a comment - Attached rebased patch, let's try again.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12751120/HBASE-13941-branch-1.0.patch
            against branch-1.0 branch at commit 3fa86a98a0897d091cc5b5318227698e46eff495.
            ATTACHMENT ID: 12751120

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 4 new or modified tests.

            +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

            +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 lineLengths. The patch does not introduce lines longer than 100

            +1 site. The mvn post-site goal succeeds with this patch.

            -1 core tests. The patch failed these unit tests:
            org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
            org.apache.hadoop.hbase.mapreduce.TestRowCounter
            org.apache.hadoop.hbase.mapreduce.TestCopyTable
            org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2
            org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
            org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
            org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat
            org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
            org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan2
            org.apache.hadoop.hbase.mapreduce.TestHRegionPartitioner
            org.apache.hadoop.hbase.mapreduce.TestTableInputFormat
            org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper

            -1 core zombie tests. There are 8 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestImportExport.testSimpleCase(TestImportExport.java:180)
            at org.apache.hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes.testMROnTableWithInvalidOperationAttr(TestImportTSVWithOperationAttributes.java:140)
            at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScan(TestMultiTableInputFormat.java:244)
            at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScanEmptyToAPP(TestMultiTableInputFormat.java:183)
            at org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat.testWithMapReduceImpl(TestTableSnapshotInputFormat.java:241)
            at org.apache.hadoop.hbase.mapreduce.TableSnapshotInputFormatTestBase.testWithMapReduce(TableSnapshotInputFormatTestBase.java:111)
            at org.apache.hadoop.hbase.mapreduce.TableSnapshotInputFormatTestBase.testWithMapReduceMultiRegion(TableSnapshotInputFormatTestBase.java:95)
            at org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScanBase.testScan(TestTableInputFormatScanBase.java:245)
            at org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan1.testScanEmptyToBBA(TestTableInputFormatScan1.java:73)
            at org.apache.hadoop.hbase.client.TestFromClientSide.testIllegalTableDescriptor(TestFromClientSide.java:5531)

            Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15154//testReport/
            Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15154//artifact/patchprocess/newFindbugsWarnings.html
            Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15154//artifact/patchprocess/checkstyle-aggregate.html

            Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15154//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12751120/HBASE-13941-branch-1.0.patch against branch-1.0 branch at commit 3fa86a98a0897d091cc5b5318227698e46eff495. ATTACHMENT ID: 12751120 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapreduce.TestRowCounter org.apache.hadoop.hbase.mapreduce.TestCopyTable org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2 org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan2 org.apache.hadoop.hbase.mapreduce.TestHRegionPartitioner org.apache.hadoop.hbase.mapreduce.TestTableInputFormat org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper -1 core zombie tests . There are 8 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestImportExport.testSimpleCase(TestImportExport.java:180) at org.apache.hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes.testMROnTableWithInvalidOperationAttr(TestImportTSVWithOperationAttributes.java:140) at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScan(TestMultiTableInputFormat.java:244) at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScanEmptyToAPP(TestMultiTableInputFormat.java:183) at org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat.testWithMapReduceImpl(TestTableSnapshotInputFormat.java:241) at org.apache.hadoop.hbase.mapreduce.TableSnapshotInputFormatTestBase.testWithMapReduce(TableSnapshotInputFormatTestBase.java:111) at org.apache.hadoop.hbase.mapreduce.TableSnapshotInputFormatTestBase.testWithMapReduceMultiRegion(TableSnapshotInputFormatTestBase.java:95) at org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScanBase.testScan(TestTableInputFormatScanBase.java:245) at org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan1.testScanEmptyToBBA(TestTableInputFormatScan1.java:73) at org.apache.hadoop.hbase.client.TestFromClientSide.testIllegalTableDescriptor(TestFromClientSide.java:5531) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15154//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15154//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15154//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15154//console This message is automatically generated.

            HadoopQA is having environment issues. I will double check results locally of course but plan to commit this tomorrow unless objection.

            apurtell Andrew Kyle Purtell added a comment - HadoopQA is having environment issues. I will double check results locally of course but plan to commit this tomorrow unless objection.

            Pushed to branch-1.0 and branch-1.1.

            apurtell Andrew Kyle Purtell added a comment - Pushed to branch-1.0 and branch-1.1.
            hudson Hudson added a comment -

            FAILURE: Integrated in HBase-1.0 #1021 (See https://builds.apache.org/job/HBase-1.0/1021/)
            HBASE-13941 Backport HBASE-13917 (Remove string comparison to identify request priority) (apurtell: rev 585cd22c90e3f56ab1441305cd4aee2827adb177)

            • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
            • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
            • hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
            hudson Hudson added a comment - FAILURE: Integrated in HBase-1.0 #1021 (See https://builds.apache.org/job/HBase-1.0/1021/ ) HBASE-13941 Backport HBASE-13917 (Remove string comparison to identify request priority) (apurtell: rev 585cd22c90e3f56ab1441305cd4aee2827adb177) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
            hudson Hudson added a comment -

            FAILURE: Integrated in HBase-1.1 #624 (See https://builds.apache.org/job/HBase-1.1/624/)
            HBASE-13941 Backport HBASE-13917 (Remove string comparison to identify request priority) (apurtell: rev 6062dc618c4d5ad69bb91fb236942484833096ee)

            • hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
            • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
            • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
            hudson Hudson added a comment - FAILURE: Integrated in HBase-1.1 #624 (See https://builds.apache.org/job/HBase-1.1/624/ ) HBASE-13941 Backport HBASE-13917 (Remove string comparison to identify request priority) (apurtell: rev 6062dc618c4d5ad69bb91fb236942484833096ee) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
            enis Enis Soztutar added a comment -

            Closing this issue after 1.0.2 release.

            enis Enis Soztutar added a comment - Closing this issue after 1.0.2 release.

            People

              apurtell Andrew Kyle Purtell
              apurtell Andrew Kyle Purtell
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: