Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13900

duplicate methods between ProtobufMagic and ProtobufUtil

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 2.0.0
    • None
    • None
    • Reviewed
    • Use ProtobufMagic methods in ProtobufUtil

    Description

      Several methods duplicated between:

      hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufMagic.java

      and

      hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java

      isPBMagicPrefix()
      isPBMagicPrefix()
      lengthOfPBMagic()

      ProtobufUtil partically references ProtobufMagic, but it also has different compare implementation ...

      Maybe this was based on packaging/signature need?

      Attachments

        1. HBASE-13900.1.patch
          3 kB
          Gabor Liptak

        Activity

          People

            gliptak Gabor Liptak
            gliptak Gabor Liptak
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: