Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13764

Backport HBASE-7782 (HBaseTestingUtility.truncateTable() not acting like CLI) to branch-1.x

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.0.2, 1.2.0, 1.1.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      HBaseTestingUtility now uses the truncate API added in HBASE-8332 so that calls to HBTU.truncateTable will behave like the shell command: effectively dropping the table and recreating a new one with the same split points.

      Previously, HBTU.truncateTable instead issued deletes for all the data already in the table. If you wish to maintain the same behavior, you should use the newly added HBTU.deleteTableData method.
      Show
      HBaseTestingUtility now uses the truncate API added in HBASE-8332 so that calls to HBTU.truncateTable will behave like the shell command: effectively dropping the table and recreating a new one with the same split points. Previously, HBTU.truncateTable instead issued deletes for all the data already in the table. If you wish to maintain the same behavior, you should use the newly added HBTU.deleteTableData method.

      Description

      Backport this test infrastructure improvement, which makes truncateTable() in HBaseTestingUtility behave in the same way it's CLI counterpart.

      1. 13764-branch-1_v1.patch
        8 kB
        Ashish Singhi
      2. 13764-branch-1.patch
        8 kB
        Ashish Singhi
      3. HBASE-13764-branch-1.patch
        7 kB
        Srikanth Srungarapu

        Issue Links

          Activity

          Hide
          enis Enis Soztutar added a comment -

          Closing this issue after 1.0.2 release.

          Show
          enis Enis Soztutar added a comment - Closing this issue after 1.0.2 release.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.1 #523 (See https://builds.apache.org/job/HBase-1.1/523/)
          HBASE-13764 Backport HBASE-7782 (HBaseTestingUtility.truncateTable() not acting like CLI) to branch-1.x (ssrungarapu: rev 77c48846f0163b6e86293bc81ff4597a62bdb5ca)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.1 #523 (See https://builds.apache.org/job/HBase-1.1/523/ ) HBASE-13764 Backport HBASE-7782 (HBaseTestingUtility.truncateTable() not acting like CLI) to branch-1.x (ssrungarapu: rev 77c48846f0163b6e86293bc81ff4597a62bdb5ca) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #946 (See https://builds.apache.org/job/HBase-1.0/946/)
          HBASE-13764 Backport HBASE-7782 (HBaseTestingUtility.truncateTable() not acting like CLI) to branch-1.x (ssrungarapu: rev e1d177cb8050fa2f3fce9319b4f6b8b04cd438ec)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.0 #946 (See https://builds.apache.org/job/HBase-1.0/946/ ) HBASE-13764 Backport HBASE-7782 (HBaseTestingUtility.truncateTable() not acting like CLI) to branch-1.x (ssrungarapu: rev e1d177cb8050fa2f3fce9319b4f6b8b04cd438ec) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.2 #128 (See https://builds.apache.org/job/HBase-1.2/128/)
          HBASE-13764 Backport HBASE-7782 (HBaseTestingUtility.truncateTable() not acting like CLI) to branch-1.x (ssrungarapu: rev 83d5f31649d36ce4ae100bde3bdd1628631ac135)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.2 #128 (See https://builds.apache.org/job/HBase-1.2/128/ ) HBASE-13764 Backport HBASE-7782 (HBaseTestingUtility.truncateTable() not acting like CLI) to branch-1.x (ssrungarapu: rev 83d5f31649d36ce4ae100bde3bdd1628631ac135) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
          Hide
          srikanth235 Srikanth Srungarapu added a comment -

          +1 lgtm.
          Thanks for chiming in Ashish. Pushed to branch-1.

          Show
          srikanth235 Srikanth Srungarapu added a comment - +1 lgtm. Thanks for chiming in Ashish. Pushed to branch-1.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12735568/13764-branch-1_v1.patch
          against branch-1 branch at commit c8c23cc3183735b02e9f43bf7115d9ce3cd2a880.
          ATTACHMENT ID: 12735568

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 19 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14197//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14197//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14197//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14197//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14197//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12735568/13764-branch-1_v1.patch against branch-1 branch at commit c8c23cc3183735b02e9f43bf7115d9ce3cd2a880. ATTACHMENT ID: 12735568 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 19 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14197//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14197//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14197//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14197//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14197//console This message is automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Patch fixing long lines.
          Javadoc is not related to this patch. Its been reported in other Hadoop QA run for branch-1 as well, like here

          Show
          ashish singhi Ashish Singhi added a comment - Patch fixing long lines. Javadoc is not related to this patch. Its been reported in other Hadoop QA run for branch-1 as well, like here
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12735533/13764-branch-1.patch
          against branch-1 branch at commit c8c23cc3183735b02e9f43bf7115d9ce3cd2a880.
          ATTACHMENT ID: 12735533

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 19 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + public HTable truncateTable(final TableName tableName, final boolean preserveRegions) throws IOException {
          + public HTable truncateTable(final byte[] tableName, final boolean preserveRegions) throws IOException {

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.test.MultithreadedTestUtil$TestingThread.run(MultithreadedTestUtil.java:189)
          at org.apache.hadoop.test.MultithreadedTestUtil$TestingThread.run(MultithreadedTestUtil.java:189)
          at org.apache.hadoop.ha.TestZKFailoverControllerStress.testRandomHealthAndDisconnects(TestZKFailoverControllerStress.java:135)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14195//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14195//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14195//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14195//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14195//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12735533/13764-branch-1.patch against branch-1 branch at commit c8c23cc3183735b02e9f43bf7115d9ce3cd2a880. ATTACHMENT ID: 12735533 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 19 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + public HTable truncateTable(final TableName tableName, final boolean preserveRegions) throws IOException { + public HTable truncateTable(final byte[] tableName, final boolean preserveRegions) throws IOException { +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.test.MultithreadedTestUtil$TestingThread.run(MultithreadedTestUtil.java:189) at org.apache.hadoop.test.MultithreadedTestUtil$TestingThread.run(MultithreadedTestUtil.java:189) at org.apache.hadoop.ha.TestZKFailoverControllerStress.testRandomHealthAndDisconnects(TestZKFailoverControllerStress.java:135) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14195//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14195//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14195//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14195//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14195//console This message is automatically generated.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Srikanth Srungarapu, no problem. I have attached the patch fixing the test failure.
          Please review.
          Looking at test failure stack trace

          org.apache.hadoop.hbase.TableNotDisabledException: org.apache.hadoop.hbase.TableNotDisabledException: testRowCounter
          	at org.apache.hadoop.hbase.master.HMaster.checkTableModifiable(HMaster.java:1850)
          	at org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.prepareTruncate(TruncateTableProcedure.java:252)
          	at org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.executeFromState(TruncateTableProcedure.java:79)
          	at org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.executeFromState(TruncateTableProcedure.java:47)
          	at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:107)
          	at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:400)
          	at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:869)
          	at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execLoop(ProcedureExecutor.java:673)
          	at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execLoop(ProcedureExecutor.java:626)
          	at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$200(ProcedureExecutor.java:70)
          	at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$1.run(ProcedureExecutor.java:413)
          
          	at org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1200)
          	at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:214)
          	at org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:288)
          	at org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$BlockingStub.truncateTable(MasterProtos.java:51038)
          	at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$4.truncateTable(ConnectionManager.java:1778)
          	at org.apache.hadoop.hbase.client.HBaseAdmin$6.call(HBaseAdmin.java:923)
          	at org.apache.hadoop.hbase.client.HBaseAdmin$6.call(HBaseAdmin.java:918)
          	at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:126)
          	at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3917)
          	at org.apache.hadoop.hbase.client.HBaseAdmin.truncateTable(HBaseAdmin.java:918)
          	at org.apache.hadoop.hbase.HBaseTestingUtility.truncateTable(HBaseTestingUtility.java:1963)
          	at org.apache.hadoop.hbase.HBaseTestingUtility.truncateTable(HBaseTestingUtility.java:1977)
          	at org.apache.hadoop.hbase.mapreduce.TestRowCounter.testRowCounterTimeRange(TestRowCounter.java:163)
          

          We should disable the table before calling truncate api. To fix the test instead of disabling the table I have updated the test to use deleteTableData method to keep it consistent with master branch code.

          Show
          ashish singhi Ashish Singhi added a comment - Srikanth Srungarapu , no problem. I have attached the patch fixing the test failure. Please review. Looking at test failure stack trace org.apache.hadoop.hbase.TableNotDisabledException: org.apache.hadoop.hbase.TableNotDisabledException: testRowCounter at org.apache.hadoop.hbase.master.HMaster.checkTableModifiable(HMaster.java:1850) at org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.prepareTruncate(TruncateTableProcedure.java:252) at org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.executeFromState(TruncateTableProcedure.java:79) at org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.executeFromState(TruncateTableProcedure.java:47) at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:107) at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:400) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:869) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execLoop(ProcedureExecutor.java:673) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execLoop(ProcedureExecutor.java:626) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$200(ProcedureExecutor.java:70) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$1.run(ProcedureExecutor.java:413) at org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1200) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:214) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:288) at org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$BlockingStub.truncateTable(MasterProtos.java:51038) at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$4.truncateTable(ConnectionManager.java:1778) at org.apache.hadoop.hbase.client.HBaseAdmin$6.call(HBaseAdmin.java:923) at org.apache.hadoop.hbase.client.HBaseAdmin$6.call(HBaseAdmin.java:918) at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:126) at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3917) at org.apache.hadoop.hbase.client.HBaseAdmin.truncateTable(HBaseAdmin.java:918) at org.apache.hadoop.hbase.HBaseTestingUtility.truncateTable(HBaseTestingUtility.java:1963) at org.apache.hadoop.hbase.HBaseTestingUtility.truncateTable(HBaseTestingUtility.java:1977) at org.apache.hadoop.hbase.mapreduce.TestRowCounter.testRowCounterTimeRange(TestRowCounter.java:163) We should disable the table before calling truncate api. To fix the test instead of disabling the table I have updated the test to use deleteTableData method to keep it consistent with master branch code.
          Hide
          srikanth235 Srikanth Srungarapu added a comment -

          Test failure TestRowCounter look related.
          Ashish Singhi Please feel free to work on this if you have time. We need this for getting HBASE-13658 into branch-1. Me swamped with other tasks at this moment.

          Show
          srikanth235 Srikanth Srungarapu added a comment - Test failure TestRowCounter look related. Ashish Singhi Please feel free to work on this if you have time. We need this for getting HBASE-13658 into branch-1. Me swamped with other tasks at this moment.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12735242/HBASE-13764-branch-1.patch
          against branch-1 branch at commit c8c23cc3183735b02e9f43bf7115d9ce3cd2a880.
          ATTACHMENT ID: 12735242

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 15 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + public HTable truncateTable(final TableName tableName, final boolean preserveRegions) throws IOException {
          + public HTable truncateTable(final byte[] tableName, final boolean preserveRegions) throws IOException {

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.mapreduce.TestRowCounter

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14177//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14177//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14177//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14177//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14177//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12735242/HBASE-13764-branch-1.patch against branch-1 branch at commit c8c23cc3183735b02e9f43bf7115d9ce3cd2a880. ATTACHMENT ID: 12735242 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 15 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + public HTable truncateTable(final TableName tableName, final boolean preserveRegions) throws IOException { + public HTable truncateTable(final byte[] tableName, final boolean preserveRegions) throws IOException { +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestRowCounter Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14177//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14177//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14177//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14177//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14177//console This message is automatically generated.

            People

            • Assignee:
              ashish singhi Ashish Singhi
              Reporter:
              srikanth235 Srikanth Srungarapu
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development