[HBASE-13729] Old hbase.regionserver.global.memstore.upperLimit and lowerLimit properties are ignored if present

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.1, 1.1.0, 2.0.0
• Fix Version/s: 1.0.2, 1.2.0, 1.1.1, 2.0.0
• Component/s: regionserver
• Hadoop Flags: Reviewed
• Assignee: Esteban Gutierrez
• Reporter: Esteban Gutierrez
• Created: 20/May/15 20:18
• Updated: 31/Aug/15 22:39
• Resolved: 05/Jun/15 20:25

Description

If hbase.regionserver.global.memstore.upperLimit or lowerLimit are present we should use them instead of hbase.regionserver.global.memstore.size or hbase.regionserver.global.memstore.size.lower.limit respectively. The current implementation of HeapMemorySizeUtil.getGlobalMemStorePercent() and getGlobalMemStoreLowerMark() asumes that if the new properties are not defined then we should use the old configurations, however the new properties are defined in hbase-default.xml which makes the old configuration names useless and this has a direct impact when doing a rolling upgrade and hbase-site.xml hasn't been changed to handle the new property names exclusively.