Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13703

ReplicateContext should not be a member of ReplicationSource

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.13, 1.0.2, 1.2.0, 1.1.1, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The ReplicateContext object is created once per ReplicationSource and then reused when we have something to ship to the sinks.

      This is a misguided optimization. ReplicateContext is very lightweight (definitely compared to the all the work and copying the ReplicationSource is doing) and, crucially, it prevent the the entries array from being collected after it was successfully copied to the sink, wasting potentially a lot of heap.
      The entries array itself holds reference to WAL entries on the heap, that now also cannot be collected.

        Attachments

        1. 13703.txt
          2 kB
          Lars Hofhansl

          Activity

            People

            • Assignee:
              lhofhansl Lars Hofhansl
              Reporter:
              lhofhansl Lars Hofhansl
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: