[HBASE-13690] Client Scanner Initialization Reformats strings every time

• Type: Improvement
• Status: Closed
• Priority: Critical
• Resolution: Later
• Assignee: Unassigned
• Reporter: John Leach
• Created: 14/May/15 21:53
• Updated: 24/Jun/22 18:55
• Resolved: 08/Oct/20 03:30

Description

The client scanner continually goes back into the conf for values...

public ClientScanner(final Configuration conf, final Scan scan, final TableName tableName,
HConnection connection, RpcRetryingCallerFactory rpcFactory,
RpcControllerFactory controllerFactory) throws IOException {
if (LOG.isTraceEnabled())

{ LOG.trace("Scan table=" + tableName + ", startRow=" + Bytes.toStringBinary(scan.getStartRow())); }

this.scan = scan;
this.tableName = tableName;
this.lastNext = System.currentTimeMillis();
this.connection = connection;
if (scan.getMaxResultSize() > 0)

{ this.maxScannerResultSize = scan.getMaxResultSize(); }

else

{ this.maxScannerResultSize = conf.getLong( HConstants.HBASE_CLIENT_SCANNER_MAX_RESULT_SIZE_KEY, HConstants.DEFAULT_HBASE_CLIENT_SCANNER_MAX_RESULT_SIZE); }

this.scannerTimeout = HBaseConfiguration.getInt(conf,
HConstants.HBASE_CLIENT_SCANNER_TIMEOUT_PERIOD,
HConstants.HBASE_REGIONSERVER_LEASE_PERIOD_KEY,
HConstants.DEFAULT_HBASE_CLIENT_SCANNER_TIMEOUT_PERIOD);

// check if application wants to collect scan metrics
initScanMetrics(scan);

// Use the caching from the Scan. If not set, use the default cache setting for this table.
if (this.scan.getCaching() > 0)

{ this.caching = this.scan.getCaching(); }

else

{ this.caching = conf.getInt( HConstants.HBASE_CLIENT_SCANNER_CACHING, HConstants.DEFAULT_HBASE_CLIENT_SCANNER_CACHING); }

this.caller = rpcFactory.<Result[]> newCaller();
this.rpcControllerFactory = controllerFactory;

initializeScannerInConstruction();
}

Issue Links

• is related to: HBASE-12128 Cache configuration and RpcController selection for Table in Connection
• is related to: HBASE-12604 Backport HBASE-12128 (Cache configuration and RpcController selection for Table in Connection) to 0.98
• is related to: HBASE-13691 HTable and RPC Code Accessing Configuration each time (Blocking)