[HBASE-13646] HRegion#execService should not try to build incomplete messages

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0, 1.1.1, 2.0.0
• Fix Version/s: 0.98.14, 1.2.0, 2.0.0
• Component/s: Coprocessors, regionserver
• Hadoop Flags: Incompatible change
• Release Note: When RegionServerCoprocessors throw an exception we will no longer attempt to build an incomplete RPC response message. Instead, the response message will be null.
• Assignee: Andrey Stepachev
• Reporter: Andrey Stepachev
• Created: 08/May/15 09:33
• Updated: 24/Jun/22 18:49
• Resolved: 06/Jul/15 16:05

Description

If some RPC service, called on region throws exception, execService still tries to build Message. In case of complex messages with required fields it complicates service code because service need to pass fake protobuf objects, so they can be barely buildable.
To mitigate that I propose to check that controller was failed and return null from call instead of failing with exception.