Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13518

Typo in hbase.hconnection.meta.lookup.threads.core parameter

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0, 1.1.0
    • Component/s: None
    • Labels:
      None

      Description

      A possible typo coming from patch in HBASE-13036.

      I think we want hbase.hconnection.meta.lookup.threads.core, not hbase.hconnection.meta.lookup.threads.max.core to be in line with the regular thread pool configuration.

                  //To start with, threads.max.core threads can hit the meta (including replicas).
                  //After that, requests will get queued up in the passed queue, and only after
                  //the queue is full, a new thread will be started
                  this.metaLookupPool = getThreadPool(
                     conf.getInt("hbase.hconnection.meta.lookup.threads.max", 128),
                     conf.getInt("hbase.hconnection.meta.lookup.threads.max.core", 10),
      
      1. 13518-1.branch-1.patch
        1 kB
        Nick Dimiduk
      2. 13518-1.txt
        0.9 kB
        Devaraj Das

        Activity

        Hide
        devaraj Devaraj Das added a comment -

        Straightforward patch.

        Show
        devaraj Devaraj Das added a comment - Straightforward patch.
        Hide
        enis Enis Soztutar added a comment -

        +1.

        Show
        enis Enis Soztutar added a comment - +1.
        Hide
        enis Enis Soztutar added a comment -

        We need this in 1.1, since we do not want a release with the param in typo. cc Nick Dimiduk.

        Show
        enis Enis Soztutar added a comment - We need this in 1.1, since we do not want a release with the param in typo. cc Nick Dimiduk .
        Hide
        ndimiduk Nick Dimiduk added a comment -

        Alright. Let's get it in.

        Show
        ndimiduk Nick Dimiduk added a comment - Alright. Let's get it in.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12728614/13518-1.txt
        against master branch at commit 01188f0e86a75b45261a7c02dd64b42e813f981a.
        ATTACHMENT ID: 12728614

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13858//testReport/
        Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13858//artifact/patchprocess/newFindbugsWarnings.html
        Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13858//artifact/patchprocess/checkstyle-aggregate.html

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13858//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12728614/13518-1.txt against master branch at commit 01188f0e86a75b45261a7c02dd64b42e813f981a. ATTACHMENT ID: 12728614 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13858//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13858//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13858//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13858//console This message is automatically generated.
        Hide
        ndimiduk Nick Dimiduk added a comment -

        Pushed to branch-1.1+

        Show
        ndimiduk Nick Dimiduk added a comment - Pushed to branch-1.1+
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-1.1 #438 (See https://builds.apache.org/job/HBase-1.1/438/)
        HBASE-13518 Typo in hbase.hconnection.meta.lookup.threads.core parameter (Devaraj Das) (ndimiduk: rev 674583f17071c2188deb8d5d9e37664f290b1028)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-1.1 #438 (See https://builds.apache.org/job/HBase-1.1/438/ ) HBASE-13518 Typo in hbase.hconnection.meta.lookup.threads.core parameter (Devaraj Das) (ndimiduk: rev 674583f17071c2188deb8d5d9e37664f290b1028) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-1.2 #34 (See https://builds.apache.org/job/HBase-1.2/34/)
        HBASE-13518 Typo in hbase.hconnection.meta.lookup.threads.core parameter (Devaraj Das) (ndimiduk: rev c678a28fca63d979d7a4b8613148362dd282e132)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-1.2 #34 (See https://builds.apache.org/job/HBase-1.2/34/ ) HBASE-13518 Typo in hbase.hconnection.meta.lookup.threads.core parameter (Devaraj Das) (ndimiduk: rev c678a28fca63d979d7a4b8613148362dd282e132) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12728708/13518-1.branch-1.patch
        against branch-1 branch at commit a725044644fbf5a6ed935595a84afa413a83fd01.
        ATTACHMENT ID: 12728708

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13859//testReport/
        Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13859//artifact/patchprocess/newFindbugsWarnings.html
        Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13859//artifact/patchprocess/checkstyle-aggregate.html

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13859//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12728708/13518-1.branch-1.patch against branch-1 branch at commit a725044644fbf5a6ed935595a84afa413a83fd01. ATTACHMENT ID: 12728708 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13859//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13859//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13859//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13859//console This message is automatically generated.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #6425 (See https://builds.apache.org/job/HBase-TRUNK/6425/)
        HBASE-13518 Typo in hbase.hconnection.meta.lookup.threads.core parameter (Devaraj Das) (ndimiduk: rev 75bb815d9954e538488c4c549f7261b5be80551b)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6425 (See https://builds.apache.org/job/HBase-TRUNK/6425/ ) HBASE-13518 Typo in hbase.hconnection.meta.lookup.threads.core parameter (Devaraj Das) (ndimiduk: rev 75bb815d9954e538488c4c549f7261b5be80551b) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
        Hide
        ndimiduk Nick Dimiduk added a comment -

        Closing issues released in 1.1.0.

        Show
        ndimiduk Nick Dimiduk added a comment - Closing issues released in 1.1.0.

          People

          • Assignee:
            devaraj Devaraj Das
            Reporter:
            enis Enis Soztutar
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development