Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13517

Publish a client artifact with shaded dependencies

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0, 1.1.0
    • Fix Version/s: 2.0.0, 1.1.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      HBase now provides added convenience artifacts that shade most dependencies. These jars hbase-shaded-client and hbase-shaded-server are meant to be used when dependency conflicts can not be solved any other way. The normal jars hbase-client and hbase-server should still be preferred when possible.

      Do not use hbase-shaded-server or hbase-shaded-client inside of a co-processor as bad things will happen.
      Show
      HBase now provides added convenience artifacts that shade most dependencies. These jars hbase-shaded-client and hbase-shaded-server are meant to be used when dependency conflicts can not be solved any other way. The normal jars hbase-client and hbase-server should still be preferred when possible. Do not use hbase-shaded-server or hbase-shaded-client inside of a co-processor as bad things will happen.

      Description

      Guava's moved on. Hadoop has not.
      Jackson moves whenever it feels like it.
      Protobuf moves with breaking point changes.

      While shading all of the time would break people that require the transitive dependencies for MR or other things. Lets provide an artifact with our dependencies shaded. Then users can have the choice to use the shaded version or the non-shaded version.

      1. HBASE-13517.patch
        14 kB
        Elliott Clark
      2. HBASE-13517-v1.patch
        20 kB
        Elliott Clark
      3. HBASE-13517-v2.patch
        18 kB
        Elliott Clark
      4. HBASE-13517-v3.patch
        16 kB
        Elliott Clark

        Issue Links

          Activity

          Hide
          stack stack added a comment -

          Guava first!

          Show
          stack stack added a comment - Guava first!
          Show
          eclark Elliott Clark added a comment - https://reviews.facebook.net/D37467
          Hide
          eclark Elliott Clark added a comment -

          Here's a patch that adds in hbase-sharded, hbase-sharded-client, and hbase-sharded-server.
          When using the sharded versions there is a trade off. You can't use HBaseTestingUtil because all of the jsp, jersey, servlet classloading. If someone has a fix for this I'd be all ears. It's just beyond me.

          Show
          eclark Elliott Clark added a comment - Here's a patch that adds in hbase-sharded, hbase-sharded-client, and hbase-sharded-server. When using the sharded versions there is a trade off. You can't use HBaseTestingUtil because all of the jsp, jersey, servlet classloading. If someone has a fix for this I'd be all ears. It's just beyond me.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726792/HBASE-13517.patch
          against master branch at commit eb82b8b3098d6a9ac62aa50189f9d4b289f38472.
          ATTACHMENT ID: 12726792

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

          -1 javac. The applied patch generated 66 javac compiler warnings (more than the master's current 5 warnings).

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
          + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
          +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
          + <!-- Hadoop and HBase depend on an old Guava, don't expose it to dependents -->
          + <shadedPattern>org.apache.hadoop.hbase.io.netty</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.org.jboss.netty</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.org.mortbay</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.org.codehaus.jackson</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.org.apache.avro</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.com.sun.jersey</shadedPattern>

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.util.TestProcessBasedCluster
          org.apache.hadoop.hbase.mapreduce.TestImportExport

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13751//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13751//artifact/patchprocess/patchReleaseAuditWarnings.txt
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13751//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13751//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13751//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13751//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726792/HBASE-13517.patch against master branch at commit eb82b8b3098d6a9ac62aa50189f9d4b289f38472. ATTACHMENT ID: 12726792 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) -1 javac . The applied patch generated 66 javac compiler warnings (more than the master's current 5 warnings). +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 1 release audit warnings (more than the master's current 0 warnings). -1 lineLengths . The patch introduces the following lines longer than 100: + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> + <!-- Hadoop and HBase depend on an old Guava, don't expose it to dependents --> + <shadedPattern>org.apache.hadoop.hbase.io.netty</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.jboss.netty</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.mortbay</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.codehaus.jackson</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.apache.avro</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.com.sun.jersey</shadedPattern> +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.util.TestProcessBasedCluster org.apache.hadoop.hbase.mapreduce.TestImportExport Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13751//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13751//artifact/patchprocess/patchReleaseAuditWarnings.txt Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13751//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13751//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13751//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13751//console This message is automatically generated.
          Hide
          eclark Elliott Clark added a comment -

          Patch to make assembly:single happy.

          Show
          eclark Elliott Clark added a comment - Patch to make assembly:single happy.
          Hide
          eclark Elliott Clark added a comment -

          Patch without extra un-needed file.

          Show
          eclark Elliott Clark added a comment - Patch without extra un-needed file.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726822/HBASE-13517-v1.patch
          against master branch at commit eb82b8b3098d6a9ac62aa50189f9d4b289f38472.
          ATTACHMENT ID: 12726822

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

          -1 javac. The applied patch generated 55 javac compiler warnings (more than the master's current 5 warnings).

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
          + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
          +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
          + <!-- Hadoop and HBase depend on an old Guava, don't expose it to dependents -->
          + <shadedPattern>org.apache.hadoop.hbase.io.netty</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.org.jboss.netty</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.org.mortbay</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.org.codehaus.jackson</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.org.apache.avro</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.com.sun.jersey</shadedPattern>

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13752//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13752//artifact/patchprocess/patchReleaseAuditWarnings.txt
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13752//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13752//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13752//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13752//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726822/HBASE-13517-v1.patch against master branch at commit eb82b8b3098d6a9ac62aa50189f9d4b289f38472. ATTACHMENT ID: 12726822 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) -1 javac . The applied patch generated 55 javac compiler warnings (more than the master's current 5 warnings). +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 1 release audit warnings (more than the master's current 0 warnings). -1 lineLengths . The patch introduces the following lines longer than 100: + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> + <!-- Hadoop and HBase depend on an old Guava, don't expose it to dependents --> + <shadedPattern>org.apache.hadoop.hbase.io.netty</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.jboss.netty</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.mortbay</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.codehaus.jackson</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.apache.avro</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.com.sun.jersey</shadedPattern> +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13752//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13752//artifact/patchprocess/patchReleaseAuditWarnings.txt Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13752//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13752//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13752//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13752//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726823/HBASE-13517-v2.patch
          against master branch at commit eb82b8b3098d6a9ac62aa50189f9d4b289f38472.
          ATTACHMENT ID: 12726823

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

          -1 javac. The applied patch generated 55 javac compiler warnings (more than the master's current 5 warnings).

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
          + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
          +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
          + <!-- Hadoop and HBase depend on an old Guava, don't expose it to dependents -->
          + <shadedPattern>org.apache.hadoop.hbase.io.netty</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.org.jboss.netty</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.org.mortbay</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.org.codehaus.jackson</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.org.apache.avro</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.com.sun.jersey</shadedPattern>

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//artifact/patchprocess/patchReleaseAuditWarnings.txt
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726823/HBASE-13517-v2.patch against master branch at commit eb82b8b3098d6a9ac62aa50189f9d4b289f38472. ATTACHMENT ID: 12726823 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) -1 javac . The applied patch generated 55 javac compiler warnings (more than the master's current 5 warnings). +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 1 release audit warnings (more than the master's current 0 warnings). -1 lineLengths . The patch introduces the following lines longer than 100: + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> + <!-- Hadoop and HBase depend on an old Guava, don't expose it to dependents --> + <shadedPattern>org.apache.hadoop.hbase.io.netty</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.jboss.netty</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.mortbay</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.codehaus.jackson</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.apache.avro</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.com.sun.jersey</shadedPattern> +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//artifact/patchprocess/patchReleaseAuditWarnings.txt Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//console This message is automatically generated.
          Hide
          busbey Sean Busbey added a comment -

          just curious, how big are the shaded jars?

          <artifactSet>
          +                                    <includes>
          +                                        <include>org.apache.hbase:*</include>
          +                                        <include>org.apache.hadoop:*</include>
          +                                        <include>org.apache.zookeeper*</include>
          +                                        <include>com.google.protobuf:*</include>
          +                                        <include>io.netty:*</include>
          +                                        <include>org.jboss.netty:*</include>
          +                                        <include>com.google.guava:*</include>
          +                                        <include>org.mortbay.jetty:*</include>
          +                                        <include>org.codehaus.jackson:*</include>
          +                                        <include>org.apache.avro:*</include>
          +                                        <include>com.sun.jersey:*</include>
          +                                        <include>com.sun.jersey.contribs:*</include>
          +                                        <include>tomcat:*</include>
          +                                    </includes>
          +                                </artifactSet>
          

          Can we avoid including things in the shaded jar that aren't in org.apache.hadoop.hbase or subpackages? That's probably the #1 source of pain with shaded artifacts.

          +                                        <shadedPattern>org.apache.hadoop.hbase.com.google.common
          +                                        </shadedPattern>
          

          nit: could we use something like org.apache.hadoop.hbase.shaded. as the prefix for all of these relocations so that there's a common package / directory for all of them?

          Show
          busbey Sean Busbey added a comment - just curious, how big are the shaded jars? <artifactSet> + <includes> + <include>org.apache.hbase:*</include> + <include>org.apache.hadoop:*</include> + <include>org.apache.zookeeper*</include> + <include>com.google.protobuf:*</include> + <include>io.netty:*</include> + <include>org.jboss.netty:*</include> + <include>com.google.guava:*</include> + <include>org.mortbay.jetty:*</include> + <include>org.codehaus.jackson:*</include> + <include>org.apache.avro:*</include> + <include>com.sun.jersey:*</include> + <include>com.sun.jersey.contribs:*</include> + <include>tomcat:*</include> + </includes> + </artifactSet> Can we avoid including things in the shaded jar that aren't in org.apache.hadoop.hbase or subpackages? That's probably the #1 source of pain with shaded artifacts. + <shadedPattern>org.apache.hadoop.hbase.com.google.common + </shadedPattern> nit: could we use something like org.apache.hadoop.hbase.shaded. as the prefix for all of these relocations so that there's a common package / directory for all of them?
          Hide
          busbey Sean Busbey added a comment -

          Can we avoid including things in the shaded jar that aren't in org.apache.hadoop.hbase or subpackages? That's probably the #1 source of pain with shaded artifacts.

          this should have been "aren't relocated in". I don't want e.g. someone who needs to use HBase and HDFS to suddenly have another jar with the hadoop packages visible just because they're trying to use our shaded artifact.

          Show
          busbey Sean Busbey added a comment - Can we avoid including things in the shaded jar that aren't in org.apache.hadoop.hbase or subpackages? That's probably the #1 source of pain with shaded artifacts. this should have been "aren't relocated in". I don't want e.g. someone who needs to use HBase and HDFS to suddenly have another jar with the hadoop packages visible just because they're trying to use our shaded artifact.
          Hide
          eclark Elliott Clark added a comment -

          I don't want e.g. someone who needs to use HBase and HDFS to suddenly have another jar with the hadoop packages visible just because they're trying to use our shaded artifact.

          We can't relocate Hadoop because that would break Configuration and several public apis. However we need to include the classes because they use guava and need to be re-written to use the new location.

          The rest of the dependencies should be relocated.

          nit: could we use something like org.apache.hadoop.hbase.shaded. as the prefix for all of these relocations so that there's a common package / directory for all of them?

          Sure let me get that and have apache-rat clean.

          Show
          eclark Elliott Clark added a comment - I don't want e.g. someone who needs to use HBase and HDFS to suddenly have another jar with the hadoop packages visible just because they're trying to use our shaded artifact. We can't relocate Hadoop because that would break Configuration and several public apis. However we need to include the classes because they use guava and need to be re-written to use the new location. The rest of the dependencies should be relocated. nit: could we use something like org.apache.hadoop.hbase.shaded. as the prefix for all of these relocations so that there's a common package / directory for all of them? Sure let me get that and have apache-rat clean.
          Hide
          eclark Elliott Clark added a comment -

          Here's a dependency:tree for a down stream project using hbase-shaded-client. ( No guava, No protobuf, No jackson, no jetty, no netty).

          [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ test-hbase-client-shade ---
          [INFO] test-hbase-client-shade:test-hbase-client-shade:jar:1.0-SNAPSHOT
          [INFO] +- org.apache.hbase:hbase-shaded-client:jar:2.0.0-SNAPSHOT:compile
          [INFO] |  +- commons-collections:commons-collections:jar:3.2.1:compile
          [INFO] |  +- commons-codec:commons-codec:jar:1.9:compile
          [INFO] |  +- commons-io:commons-io:jar:2.4:compile
          [INFO] |  +- commons-lang:commons-lang:jar:2.6:compile
          [INFO] |  +- commons-logging:commons-logging:jar:1.2:compile
          [INFO] |  +- com.google.code.findbugs:jsr305:jar:1.3.9:compile
          [INFO] |  +- org.slf4j:slf4j-api:jar:1.7.7:compile
          [INFO] |  +- org.slf4j:slf4j-log4j12:jar:1.6.1:compile
          [INFO] |  +- org.apache.htrace:htrace-core:jar:3.1.0-incubating:compile
          [INFO] |  +- org.jruby.jcodings:jcodings:jar:1.0.8:compile
          [INFO] |  +- org.jruby.joni:joni:jar:2.1.2:compile
          [INFO] |  +- org.apache.httpcomponents:httpclient:jar:4.2.5:compile
          [INFO] |  +- org.apache.httpcomponents:httpcore:jar:4.2.4:compile
          [INFO] |  +- org.apache.directory.server:apacheds-kerberos-codec:jar:2.0.0-M15:compile
          [INFO] |  +- org.apache.directory.server:apacheds-i18n:jar:2.0.0-M15:compile
          [INFO] |  +- org.apache.directory.api:api-asn1-api:jar:1.0.0-M20:compile
          [INFO] |  +- org.apache.directory.api:api-util:jar:1.0.0-M20:compile
          [INFO] |  +- commons-cli:commons-cli:jar:1.2:compile
          [INFO] |  +- org.apache.commons:commons-math3:jar:3.1.1:compile
          [INFO] |  +- xmlenc:xmlenc:jar:0.52:compile
          [INFO] |  +- commons-httpclient:commons-httpclient:jar:3.1:compile
          [INFO] |  +- commons-net:commons-net:jar:3.1:compile
          [INFO] |  +- commons-el:commons-el:jar:1.0:runtime
          [INFO] |  +- commons-configuration:commons-configuration:jar:1.6:compile
          [INFO] |  +- commons-digester:commons-digester:jar:1.8:compile
          [INFO] |  +- commons-beanutils:commons-beanutils:jar:1.7.0:compile
          [INFO] |  +- commons-beanutils:commons-beanutils-core:jar:1.8.0:compile
          [INFO] |  +- com.thoughtworks.paranamer:paranamer:jar:2.3:compile
          [INFO] |  +- org.xerial.snappy:snappy-java:jar:1.0.4.1:compile
          [INFO] |  +- com.jcraft:jsch:jar:0.1.42:compile
          [INFO] |  +- org.apache.commons:commons-compress:jar:1.4.1:compile
          [INFO] |  +- org.tukaani:xz:jar:1.0:compile
          [INFO] |  +- javax.xml.bind:jaxb-api:jar:2.2.2:compile
          [INFO] |  +- javax.activation:activation:jar:1.1:compile
          [INFO] |  +- com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile
          [INFO] |  \- log4j:log4j:jar:1.2.17:compile
          [INFO] \- junit:junit:jar:4.11:test
          [INFO]    \- org.hamcrest:hamcrest-core:jar:1.3:test
          

          Should we re-locate the commons-* stuff too ? I think we should leave the loggin stuff exposed as that stuff relies on loading classes by name; however the rest can move if it's wanted.

          Sizes as things stand:

          -rw-r--r--  1 elliott  THEFACEBOOK\Domain Users    19M Apr 21 08:56 hbase-shaded-client-2.0.0-SNAPSHOT.jar
          -rw-r--r--  1 elliott  THEFACEBOOK\Domain Users    36M Apr 21 08:57 hbase-shaded-server-2.0.0-SNAPSHOT.jar
          
          Show
          eclark Elliott Clark added a comment - Here's a dependency:tree for a down stream project using hbase-shaded-client. ( No guava, No protobuf, No jackson, no jetty, no netty). [INFO] --- maven-dependency-plugin:2.8:tree ( default -cli) @ test-hbase-client-shade --- [INFO] test-hbase-client-shade:test-hbase-client-shade:jar:1.0-SNAPSHOT [INFO] +- org.apache.hbase:hbase-shaded-client:jar:2.0.0-SNAPSHOT:compile [INFO] | +- commons-collections:commons-collections:jar:3.2.1:compile [INFO] | +- commons-codec:commons-codec:jar:1.9:compile [INFO] | +- commons-io:commons-io:jar:2.4:compile [INFO] | +- commons-lang:commons-lang:jar:2.6:compile [INFO] | +- commons-logging:commons-logging:jar:1.2:compile [INFO] | +- com.google.code.findbugs:jsr305:jar:1.3.9:compile [INFO] | +- org.slf4j:slf4j-api:jar:1.7.7:compile [INFO] | +- org.slf4j:slf4j-log4j12:jar:1.6.1:compile [INFO] | +- org.apache.htrace:htrace-core:jar:3.1.0-incubating:compile [INFO] | +- org.jruby.jcodings:jcodings:jar:1.0.8:compile [INFO] | +- org.jruby.joni:joni:jar:2.1.2:compile [INFO] | +- org.apache.httpcomponents:httpclient:jar:4.2.5:compile [INFO] | +- org.apache.httpcomponents:httpcore:jar:4.2.4:compile [INFO] | +- org.apache.directory.server:apacheds-kerberos-codec:jar:2.0.0-M15:compile [INFO] | +- org.apache.directory.server:apacheds-i18n:jar:2.0.0-M15:compile [INFO] | +- org.apache.directory.api:api-asn1-api:jar:1.0.0-M20:compile [INFO] | +- org.apache.directory.api:api-util:jar:1.0.0-M20:compile [INFO] | +- commons-cli:commons-cli:jar:1.2:compile [INFO] | +- org.apache.commons:commons-math3:jar:3.1.1:compile [INFO] | +- xmlenc:xmlenc:jar:0.52:compile [INFO] | +- commons-httpclient:commons-httpclient:jar:3.1:compile [INFO] | +- commons-net:commons-net:jar:3.1:compile [INFO] | +- commons-el:commons-el:jar:1.0:runtime [INFO] | +- commons-configuration:commons-configuration:jar:1.6:compile [INFO] | +- commons-digester:commons-digester:jar:1.8:compile [INFO] | +- commons-beanutils:commons-beanutils:jar:1.7.0:compile [INFO] | +- commons-beanutils:commons-beanutils-core:jar:1.8.0:compile [INFO] | +- com.thoughtworks.paranamer:paranamer:jar:2.3:compile [INFO] | +- org.xerial.snappy:snappy-java:jar:1.0.4.1:compile [INFO] | +- com.jcraft:jsch:jar:0.1.42:compile [INFO] | +- org.apache.commons:commons-compress:jar:1.4.1:compile [INFO] | +- org.tukaani:xz:jar:1.0:compile [INFO] | +- javax.xml.bind:jaxb-api:jar:2.2.2:compile [INFO] | +- javax.activation:activation:jar:1.1:compile [INFO] | +- com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile [INFO] | \- log4j:log4j:jar:1.2.17:compile [INFO] \- junit:junit:jar:4.11:test [INFO] \- org.hamcrest:hamcrest-core:jar:1.3:test Should we re-locate the commons-* stuff too ? I think we should leave the loggin stuff exposed as that stuff relies on loading classes by name; however the rest can move if it's wanted. Sizes as things stand: -rw-r--r-- 1 elliott THEFACEBOOK\Domain Users 19M Apr 21 08:56 hbase-shaded-client-2.0.0-SNAPSHOT.jar -rw-r--r-- 1 elliott THEFACEBOOK\Domain Users 36M Apr 21 08:57 hbase-shaded-server-2.0.0-SNAPSHOT.jar
          Hide
          busbey Sean Busbey added a comment -

          Should we re-locate the commons-* stuff too ? I think we should leave the loggin stuff exposed as that stuff relies on loading classes by name; however the rest can move if it's wanted.

          I'm generally of the opinion that you should relocate absolutely everything you can.

          Is Hadoop's Configuration really in our API?

          Show
          busbey Sean Busbey added a comment - Should we re-locate the commons-* stuff too ? I think we should leave the loggin stuff exposed as that stuff relies on loading classes by name; however the rest can move if it's wanted. I'm generally of the opinion that you should relocate absolutely everything you can. Is Hadoop's Configuration really in our API?
          Hide
          eclark Elliott Clark added a comment -

          I'm generally of the opinion that you should relocate absolutely everything you can.

          K, working on it.

          Is Hadoop's Configuration really in our API?

          Yeah return values for HBaseConfigurations and as function parameters for Connection creation and MR job submission.

          Show
          eclark Elliott Clark added a comment - I'm generally of the opinion that you should relocate absolutely everything you can. K, working on it. Is Hadoop's Configuration really in our API? Yeah return values for HBaseConfigurations and as function parameters for Connection creation and MR job submission.
          Hide
          eclark Elliott Clark added a comment -

          Shaded everything minus logging deps since they rely on config for class loading. Here's what the resulting dependency tree of a downstreamer would be:

          [INFO] test-hbase-client-shade:test-hbase-client-shade:jar:1.0-SNAPSHOT
          [INFO] +- org.apache.hbase:hbase-shaded-server:jar:2.0.0-SNAPSHOT:compile
          [INFO] |  +- org.slf4j:slf4j-api:jar:1.7.7:compile
          [INFO] |  +- commons-logging:commons-logging:jar:1.2:compile
          [INFO] |  +- org.slf4j:slf4j-log4j12:jar:1.6.1:compile
          [INFO] |  +- org.apache.htrace:htrace-core:jar:3.1.0-incubating:compile
          [INFO] |  +- log4j:log4j:jar:1.2.17:compile
          [INFO] |  \- com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile
          [INFO] \- junit:junit:jar:4.11:test
          [INFO]    \- org.hamcrest:hamcrest-core:jar:1.3:test
          
          Show
          eclark Elliott Clark added a comment - Shaded everything minus logging deps since they rely on config for class loading. Here's what the resulting dependency tree of a downstreamer would be: [INFO] test-hbase-client-shade:test-hbase-client-shade:jar:1.0-SNAPSHOT [INFO] +- org.apache.hbase:hbase-shaded-server:jar:2.0.0-SNAPSHOT:compile [INFO] | +- org.slf4j:slf4j-api:jar:1.7.7:compile [INFO] | +- commons-logging:commons-logging:jar:1.2:compile [INFO] | +- org.slf4j:slf4j-log4j12:jar:1.6.1:compile [INFO] | +- org.apache.htrace:htrace-core:jar:3.1.0-incubating:compile [INFO] | +- log4j:log4j:jar:1.2.17:compile [INFO] | \- com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile [INFO] \- junit:junit:jar:4.11:test [INFO] \- org.hamcrest:hamcrest-core:jar:1.3:test
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12727291/HBASE-13517-v3.patch
          against master branch at commit 2bf8cda4f68940909e9bcfdf8ae41cc751a49c7d.
          ATTACHMENT ID: 12727291

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

          -1 javac. The applied patch generated 113 javac compiler warnings (more than the master's current 5 warnings).

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
          + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
          +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
          + <dependencyReducedPomLocation>$

          {project.build.directory}

          /dependency-reduced-pom.xml</dependencyReducedPomLocation>
          + <shadedPattern>org.apache.hadoop.hbase.shaded.com</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.shaded.net</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.shaded.javax</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.shaded.io</shadedPattern>
          + <shadedPattern>org.apache.hadoop.hbase.shaded.org</shadedPattern>

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13779//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13779//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13779//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13779//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13779//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12727291/HBASE-13517-v3.patch against master branch at commit 2bf8cda4f68940909e9bcfdf8ae41cc751a49c7d. ATTACHMENT ID: 12727291 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) -1 javac . The applied patch generated 113 javac compiler warnings (more than the master's current 5 warnings). +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> + <dependencyReducedPomLocation>$ {project.build.directory} /dependency-reduced-pom.xml</dependencyReducedPomLocation> + <shadedPattern>org.apache.hadoop.hbase.shaded.com</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.shaded.net</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.shaded.javax</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.shaded.io</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.shaded.org</shadedPattern> +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13779//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13779//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13779//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13779//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13779//console This message is automatically generated.
          Hide
          eclark Elliott Clark added a comment -

          Thoughts on this?

          I've tested that the client jar works and I can use it to scan data from a cluster.
          There are no deps other than hadoop that aren't relocated.
          Guava and others can be on the classpath with different versions and everything works well.

          Show
          eclark Elliott Clark added a comment - Thoughts on this? I've tested that the client jar works and I can use it to scan data from a cluster. There are no deps other than hadoop that aren't relocated. Guava and others can be on the classpath with different versions and everything works well.
          Hide
          ndimiduk Nick Dimiduk added a comment -

          I think giving the user the option to isolate our environment from their own isn't a bad thing. Are we making trouble by pushing such an artifact to the maven repos?

          Does this qualify as a work-around for HBASE-13149 ?

          Show
          ndimiduk Nick Dimiduk added a comment - I think giving the user the option to isolate our environment from their own isn't a bad thing. Are we making trouble by pushing such an artifact to the maven repos? Does this qualify as a work-around for HBASE-13149 ?
          Hide
          eclark Elliott Clark added a comment -

          This might work around that issue. However it's more intended to allow users the freedom to choose which dependencies in their own servers without regard to hold old or crufty our dependencies are. The other thing is it's pretty hard to debug when there are incorrect versions on the classpath since the errors can happen long after the process starts.

          Are we making trouble by pushing such an artifact to the maven repos?

          It's a little more work for us, but I think for the end users it would be worth it. ( The guava issue has bitten two different internal users separately in the past week alone).

          There are better long term solutions however all of them require hadoop to do pretty drastic things, so I think this is the best solution for downstreamers who need/want to use versions that don't line up with hadop and HBase

          Show
          eclark Elliott Clark added a comment - This might work around that issue. However it's more intended to allow users the freedom to choose which dependencies in their own servers without regard to hold old or crufty our dependencies are. The other thing is it's pretty hard to debug when there are incorrect versions on the classpath since the errors can happen long after the process starts. Are we making trouble by pushing such an artifact to the maven repos? It's a little more work for us, but I think for the end users it would be worth it. ( The guava issue has bitten two different internal users separately in the past week alone). There are better long term solutions however all of them require hadoop to do pretty drastic things, so I think this is the best solution for downstreamers who need/want to use versions that don't line up with hadop and HBase
          Hide
          ndimiduk Nick Dimiduk added a comment -

          Alright, +1 from me. Sean Busbey any other concerns? Andrew Purtell, Lars Hofhansl, stack Enis Soztutar?

          Show
          ndimiduk Nick Dimiduk added a comment - Alright, +1 from me. Sean Busbey any other concerns? Andrew Purtell , Lars Hofhansl , stack Enis Soztutar ?
          Hide
          busbey Sean Busbey added a comment -

          Could we shade htrace out as well?

          What's the expected use case for shaded-server?

          Show
          busbey Sean Busbey added a comment - Could we shade htrace out as well? What's the expected use case for shaded-server?
          Hide
          eclark Elliott Clark added a comment -

          We can't shade out HTrace otherwise there would be no way to start tracing on a request.

          Show
          eclark Elliott Clark added a comment - We can't shade out HTrace otherwise there would be no way to start tracing on a request.
          Hide
          ndimiduk Nick Dimiduk added a comment -

          I believe the shaded server jar is for map reduce jobs.

          Show
          ndimiduk Nick Dimiduk added a comment - I believe the shaded server jar is for map reduce jobs.
          Hide
          busbey Sean Busbey added a comment -

          +1 presuming we document that hbase-server-shaded is just for MR job, to avoid people trying to use it for e.g. writing coprocessors or replication implementations (though I'd prefer we get HBASE-12946 / HBASE-11843 for those MR classes we expect users to make use of instead).

          Show
          busbey Sean Busbey added a comment - +1 presuming we document that hbase-server-shaded is just for MR job, to avoid people trying to use it for e.g. writing coprocessors or replication implementations (though I'd prefer we get HBASE-12946 / HBASE-11843 for those MR classes we expect users to make use of instead).
          Hide
          eclark Elliott Clark added a comment -

          Thanks for the reviews.

          Sean Busbey I totally want a better distribution of code into jars. And I owe a couple of doc jiras for 1.1 so let me file another one and get started on those.

          Show
          eclark Elliott Clark added a comment - Thanks for the reviews. Sean Busbey I totally want a better distribution of code into jars. And I owe a couple of doc jiras for 1.1 so let me file another one and get started on those.
          Hide
          busbey Sean Busbey added a comment -

          Elliott Clark could you add a release note?

          Show
          busbey Sean Busbey added a comment - Elliott Clark could you add a release note?
          Hide
          ndimiduk Nick Dimiduk added a comment -

          Elliott Clark

          And I owe a couple of doc jiras for 1.1

          IIRC, there's a doc ticket for memcached block cache as well I may have bumped those out of 1.1.0. Mind setting the fixVersion on them so I can make sure they make the release? Thanks.

          Show
          ndimiduk Nick Dimiduk added a comment - Elliott Clark And I owe a couple of doc jiras for 1.1 IIRC, there's a doc ticket for memcached block cache as well I may have bumped those out of 1.1.0. Mind setting the fixVersion on them so I can make sure they make the release? Thanks.
          Hide
          eclark Elliott Clark added a comment -

          IIRC, there's a doc ticket for memcached block cache as well

          Yeah that's the one that I was thinking about.

          Show
          eclark Elliott Clark added a comment - IIRC, there's a doc ticket for memcached block cache as well Yeah that's the one that I was thinking about.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.1 #439 (See https://builds.apache.org/job/HBase-1.1/439/)
          HBASE-13517 Publish a client artifact with shaded dependencies (eclark: rev da9f06318d6c5021306b3de288fb1b81983cea1c)

          • .gitignore
          • hbase-shaded/hbase-shaded-client/pom.xml
          • hbase-assembly/src/main/assembly/src.xml
          • hbase-shaded/hbase-shaded-server/pom.xml
          • hbase-shaded/pom.xml
          • hbase-assembly/src/main/assembly/hadoop-two-compat.xml
          • pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.1 #439 (See https://builds.apache.org/job/HBase-1.1/439/ ) HBASE-13517 Publish a client artifact with shaded dependencies (eclark: rev da9f06318d6c5021306b3de288fb1b81983cea1c) .gitignore hbase-shaded/hbase-shaded-client/pom.xml hbase-assembly/src/main/assembly/src.xml hbase-shaded/hbase-shaded-server/pom.xml hbase-shaded/pom.xml hbase-assembly/src/main/assembly/hadoop-two-compat.xml pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.2 #36 (See https://builds.apache.org/job/HBase-1.2/36/)
          HBASE-13517 Publish a client artifact with shaded dependencies (eclark: rev d9bf56ab3a40ced5ff77a0d2df8d76e1200f7b22)

          • hbase-assembly/src/main/assembly/hadoop-two-compat.xml
          • .gitignore
          • hbase-shaded/hbase-shaded-server/pom.xml
          • pom.xml
          • hbase-shaded/hbase-shaded-client/pom.xml
          • hbase-shaded/pom.xml
          • hbase-assembly/src/main/assembly/src.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.2 #36 (See https://builds.apache.org/job/HBase-1.2/36/ ) HBASE-13517 Publish a client artifact with shaded dependencies (eclark: rev d9bf56ab3a40ced5ff77a0d2df8d76e1200f7b22) hbase-assembly/src/main/assembly/hadoop-two-compat.xml .gitignore hbase-shaded/hbase-shaded-server/pom.xml pom.xml hbase-shaded/hbase-shaded-client/pom.xml hbase-shaded/pom.xml hbase-assembly/src/main/assembly/src.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #6428 (See https://builds.apache.org/job/HBase-TRUNK/6428/)
          HBASE-13517 Publish a client artifact with shaded dependencies (eclark: rev d2c19416a2afb6c47f79037702411bb63a80e9e6)

          • pom.xml
          • hbase-assembly/src/main/assembly/hadoop-two-compat.xml
          • hbase-shaded/hbase-shaded-client/pom.xml
          • .gitignore
          • hbase-shaded/hbase-shaded-server/pom.xml
          • hbase-shaded/pom.xml
          • hbase-assembly/src/main/assembly/src.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6428 (See https://builds.apache.org/job/HBase-TRUNK/6428/ ) HBASE-13517 Publish a client artifact with shaded dependencies (eclark: rev d2c19416a2afb6c47f79037702411bb63a80e9e6) pom.xml hbase-assembly/src/main/assembly/hadoop-two-compat.xml hbase-shaded/hbase-shaded-client/pom.xml .gitignore hbase-shaded/hbase-shaded-server/pom.xml hbase-shaded/pom.xml hbase-assembly/src/main/assembly/src.xml
          Hide
          ndimiduk Nick Dimiduk added a comment -

          I see no shaded jars in the tgz. These only for maven, or did we want to ship them as well? maybe a new top level directory called "shaded"?

          Show
          ndimiduk Nick Dimiduk added a comment - I see no shaded jars in the tgz. These only for maven, or did we want to ship them as well? maybe a new top level directory called "shaded"?
          Hide
          eclark Elliott Clark added a comment -

          I was thinking of them as maven only. Though adding a new top level directory would work well too. Anything that keeps them off of the classpath.

          Show
          eclark Elliott Clark added a comment - I was thinking of them as maven only. Though adding a new top level directory would work well too. Anything that keeps them off of the classpath.
          Hide
          ndimiduk Nick Dimiduk added a comment -

          Closing issues released in 1.1.0.

          Show
          ndimiduk Nick Dimiduk added a comment - Closing issues released in 1.1.0.

            People

            • Assignee:
              eclark Elliott Clark
              Reporter:
              eclark Elliott Clark
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development