Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13291 Lift the scan ceiling
  3. HBASE-13496

Make Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo inlineable

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.1.0, 1.0.2, 2.0.0
    • Scanners
    • None
    • Reviewed

    Description

      While testing with some other perf comparisons I have noticed that the above method (which is very hot in read path) is not getting inline

      @ 16 org.apache.hadoop.hbase.util.Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo (364 bytes) hot method too big

      We can do minor refactoring to make it inlineable.

      Attachments

        1. ByteBufferUtils.java
          6 kB
          Anoop Sam John
        2. HBASE-13496.patch
          4 kB
          Anoop Sam John
        3. HBASE-13496.patch
          4 kB
          Anoop Sam John
        4. OffheapVsOnHeapCompareTest.java
          1 kB
          Anoop Sam John
        5. onheapoffheapcompare.tgz
          2.00 MB
          Michael Stack

        Activity

          People

            anoop.hbase Anoop Sam John
            anoop.hbase Anoop Sam John
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: