Details

    • Reviewed

    Description

      When there are many delete markers, the probe on the first region will timeout and generate a false alarm.

      Attachments

        1. HBASE-13377-branch-1.patch
          2 kB
          Andrew Kyle Purtell
        2. HBASE-13377-V1.patch
          0.6 kB
          Michael Stack
        3. HBASE-13377-V1.patch
          0.6 kB
          He Liangliang
        4. HBASE-13377-V0.patch
          3 kB
          He Liangliang

        Activity

          heliangliang He Liangliang added a comment -

          make a raw scan to get the 1st raw row as the probe key

          heliangliang He Liangliang added a comment - make a raw scan to get the 1st raw row as the probe key
          heliangliang He Liangliang added a comment -

          update patch, just add raw flag, since it's allowed to specify the cf for a raw scan in trunk.

          heliangliang He Liangliang added a comment - update patch, just add raw flag, since it's allowed to specify the cf for a raw scan in trunk.
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12709152/HBASE-13377-V0.patch
          against master branch at commit 5789779affcec843657156e4e15dc8baf221d0d5.
          ATTACHMENT ID: 12709152

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13546//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13546//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13546//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13546//console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12709152/HBASE-13377-V0.patch against master branch at commit 5789779affcec843657156e4e15dc8baf221d0d5. ATTACHMENT ID: 12709152 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13546//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13546//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13546//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13546//console This message is automatically generated.
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12709156/HBASE-13377-V1.patch
          against master branch at commit 5789779affcec843657156e4e15dc8baf221d0d5.
          ATTACHMENT ID: 12709156

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.util.TestProcessBasedCluster
          org.apache.hadoop.hbase.mapreduce.TestImportExport

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13547//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13547//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13547//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13547//console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12709156/HBASE-13377-V1.patch against master branch at commit 5789779affcec843657156e4e15dc8baf221d0d5. ATTACHMENT ID: 12709156 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.util.TestProcessBasedCluster org.apache.hadoop.hbase.mapreduce.TestImportExport Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13547//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13547//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13547//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13547//console This message is automatically generated.
          stack Michael Stack added a comment -

          Retry

          stack Michael Stack added a comment - Retry
          stack Michael Stack added a comment -

          +1 on patch. Nice one.

          stack Michael Stack added a comment - +1 on patch. Nice one.
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723688/HBASE-13377-V1.patch
          against master branch at commit 4d5a11e082e3b18100bb533626b51ebefb62fc7e.
          ATTACHMENT ID: 12723688

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13599//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13599//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13599//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13599//console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723688/HBASE-13377-V1.patch against master branch at commit 4d5a11e082e3b18100bb533626b51ebefb62fc7e. ATTACHMENT ID: 12723688 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13599//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13599//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13599//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13599//console This message is automatically generated.
          stack Michael Stack added a comment -

          Pushed to master branch. Thanks for the patch He Liangliang

          stack Michael Stack added a comment - Pushed to master branch. Thanks for the patch He Liangliang
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #6355 (See https://builds.apache.org/job/HBase-TRUNK/6355/)
          HBASE-13377 Canary may generate false alarm on the first region when there are many delete markers (He Liangliang) (stack: rev 9ac3c5f16d8e207d68ce4c2e3ad0157532009f94)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6355 (See https://builds.apache.org/job/HBase-TRUNK/6355/ ) HBASE-13377 Canary may generate false alarm on the first region when there are many delete markers (He Liangliang) (stack: rev 9ac3c5f16d8e207d68ce4c2e3ad0157532009f94) hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java

          This seems like a nice one liner improvement that should be applied everywhere, not just trunk. Enis Soztutar Nick Dimiduk

          apurtell Andrew Kyle Purtell added a comment - This seems like a nice one liner improvement that should be applied everywhere, not just trunk. Enis Soztutar Nick Dimiduk
          ndimiduk Nick Dimiduk added a comment -

          +1 for 1.1

          ndimiduk Nick Dimiduk added a comment - +1 for 1.1

          Picked back to 1.x branches and 0.98.

          Adds the call to scan#setRaw.

          I also made sure get and scan parameters are consistent across all branches.

          apurtell Andrew Kyle Purtell added a comment - Picked back to 1.x branches and 0.98. Adds the call to scan#setRaw. I also made sure get and scan parameters are consistent across all branches.
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.2 #48 (See https://builds.apache.org/job/HBase-1.2/48/)
          HBASE-13377 Canary may generate false alarm on the first region when there are many delete markers (He Liangliang) (apurtell: rev ac190e807739ccf5ae2236b8d39c342d23630358)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.2 #48 (See https://builds.apache.org/job/HBase-1.2/48/ ) HBASE-13377 Canary may generate false alarm on the first region when there are many delete markers (He Liangliang) (apurtell: rev ac190e807739ccf5ae2236b8d39c342d23630358) hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.1 #455 (See https://builds.apache.org/job/HBase-1.1/455/)
          HBASE-13377 Canary may generate false alarm on the first region when there are many delete markers (He Liangliang) (apurtell: rev ccc34d578f276399ea66fa544811c71f2f2f6da3)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.1 #455 (See https://builds.apache.org/job/HBase-1.1/455/ ) HBASE-13377 Canary may generate false alarm on the first region when there are many delete markers (He Liangliang) (apurtell: rev ccc34d578f276399ea66fa544811c71f2f2f6da3) hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #893 (See https://builds.apache.org/job/HBase-1.0/893/)
          HBASE-13377 Canary may generate false alarm on the first region when there are many delete markers (He Liangliang) (apurtell: rev 722aebd65bbcbac253e8e56f19ad772a1a994fd7)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.0 #893 (See https://builds.apache.org/job/HBase-1.0/893/ ) HBASE-13377 Canary may generate false alarm on the first region when there are many delete markers (He Liangliang) (apurtell: rev 722aebd65bbcbac253e8e56f19ad772a1a994fd7) hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #923 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/923/)
          HBASE-13377 Canary may generate false alarm on the first region when there are many delete markers (He Liangliang) (apurtell: rev bd3f2fb894ebca57ac5ca2b765e7c421175cef4c)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #923 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/923/ ) HBASE-13377 Canary may generate false alarm on the first region when there are many delete markers (He Liangliang) (apurtell: rev bd3f2fb894ebca57ac5ca2b765e7c421175cef4c) hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98 #971 (See https://builds.apache.org/job/HBase-0.98/971/)
          HBASE-13377 Canary may generate false alarm on the first region when there are many delete markers (He Liangliang) (apurtell: rev bd3f2fb894ebca57ac5ca2b765e7c421175cef4c)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #971 (See https://builds.apache.org/job/HBase-0.98/971/ ) HBASE-13377 Canary may generate false alarm on the first region when there are many delete markers (He Liangliang) (apurtell: rev bd3f2fb894ebca57ac5ca2b765e7c421175cef4c) hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
          enis Enis Soztutar added a comment -

          Closing this issue after 1.0.2 release.

          enis Enis Soztutar added a comment - Closing this issue after 1.0.2 release.

          People

            heliangliang He Liangliang
            heliangliang He Liangliang
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack